netdev - Re: [PATCH net-next v2 12/12] net: homa: create Makefile and Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXJAmzQ=xrpr46aF_qeU3mAwDdCaXWXnRKOc+hG8tyihCW9hw@mail.gmail.com>
Date: Mon, 2 Dec 2024 15:27:01 -0800
From: John Ousterhout <ouster@...stanford.edu>
To: "D. Wythe" <alibuda@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, linux-api@...r.kernel.org
Subject: Re: [PATCH net-next v2 12/12] net: homa: create Makefile and Kconfig

On Mon, Nov 25, 2024 at 8:27 PM D. Wythe <alibuda@...ux.alibaba.com> wrote:
>
> On 11/12/24 7:40 AM, John Ousterhout wrote:
>
> A small formatting issue, perhaps you're using spaces?

Yep; I fixed the formatting in Kconfig based on input from Randy
Dunlap earlier in this message train.

> > +menuconfig HOMA
> > +     tristate "The Homa transport protocol"
> > +     depends on INET
> > +     depends on IPV6
>
> Can HOMA run in an environment without IPv6（IPv4 only)? If so, depends is not suitable here. Perhaps
> what you need is to implement different branches in the code using
>
> #if IS_ENABLED(CONFIG_IPV6)

No, Homa really can't run in environments without IPv6: internally,
Homa stores all addresses as IPv6 addresses, converting to/from IPv4
at the interfaces with other kernel functions. Hopefully that is not a
problem? And given that, "depends on IPV6" is OK, right?

-John-