netdev - Re: [PATCH v3 net] ipmr: tune the ipmr_can_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLoQhK36PV6-2iizyK+LnawKaPdqOsXzHCSPt36=Xeacw@mail.gmail.com>
Date: Tue, 3 Dec 2024 11:59:08 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>, David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH v3 net] ipmr: tune the ipmr_can_free_table() checks.

On Tue, Dec 3, 2024 at 10:48 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> Eric reported a syzkaller-triggered splat caused by recent ipmr changes:
>
>
> The root cause is a network namespace creation failing after successful
> initialization of the ipmr subsystem. Such a case is not currently
> matched by the ipmr_can_free_table() helper.
>
> New namespaces are zeroed on allocation and inserted into net ns list
> only after successful creation; when deleting an ipmr table, the list
> next pointer can be NULL only on netns initialization failure.
>
> Update the ipmr_can_free_table() checks leveraging such condition.
>
> Reported-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot+6e8cb445d4b43d006e0c@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=6e8cb445d4b43d006e0c
> Fixes: 11b6e701bce9 ("ipmr: add debug check for mr table cleanup")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !