netdev - Re: [PATCH net-next v1 7/7] netlink: specs: wireless: add a spec for nl80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <016ba49a8b072f89fc4340341be166e26cc1b9a8.camel@sipsolutions.net>
Date: Tue, 03 Dec 2024 14:12:34 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Donald Hunter <donald.hunter@...il.com>, netdev@...r.kernel.org, Jakub
 Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, linux-wireless@...r.kernel.org
Cc: donald.hunter@...hat.com
Subject: Re: [PATCH net-next v1 7/7] netlink: specs: wireless: add a spec
 for nl80211

On Tue, 2024-12-03 at 13:06 +0000, Donald Hunter wrote:
> Add a rudimentary YNL spec for nl80211 that covers get-wiphy and
> get-interface.

OK, that says what it's doing, but why?

Also, I don't know how we will maintain this if it's not tied to any
kernel code. What do you suggest? Do you want to just maintain it
following the nl80211.h spec all the time?

> +operations:
> +  enum-model: directional
> +  list:
> +    -
> +      name: get-wiphy
> +      doc: Get information about a wiphy or dump a list of all wiphys
> +      attribute-set: nl80211-attrs
> +      do:
> +        request:
> +          value: 1
> +          attributes:
> +            - wiphy
> +        reply:
> +          value: 3
> +      dump:
> +        request:
> +          attributes:
> +            - wiphy
> 

This already seems wrong - dump wiphy really should unconditionally
include NL80211_ATTR_SPLIT_WIPHY_DUMP these days.

johannes