netdev - Re: [PATCH] selftests/net: call sendmmsg via udpgso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <674f21ef3048c_19a62294c6@willemb.c.googlers.com.notmuch>
Date: Tue, 03 Dec 2024 10:21:19 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Kenjiro Nakayama <nakayamakenjiro@...il.com>, 
 Pablo Neira Ayuso <pablo@...filter.org>, 
 Jozsef Kadlecsik <kadlec@...filter.org>, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Simon Horman <horms@...nel.org>, 
 Alan Stern <stern@...land.harvard.edu>, 
 Andrea Parri <parri.andrea@...il.com>, 
 Will Deacon <will@...nel.org>, 
 Peter Zijlstra <peterz@...radead.org>, 
 Boqun Feng <boqun.feng@...il.com>, 
 Nicholas Piggin <npiggin@...il.com>, 
 David Howells <dhowells@...hat.com>, 
 Jade Alglave <j.alglave@....ac.uk>, 
 Luc Maranget <luc.maranget@...ia.fr>, 
 "Paul E. McKenney" <paulmck@...nel.org>, 
 Akira Yokosawa <akiyks@...il.com>, 
 Daniel Lustig <dlustig@...dia.com>, 
 Joel Fernandes <joel@...lfernandes.org>, 
 Shuah Khan <shuah@...nel.org>
Cc: netfilter-devel@...r.kernel.org, 
 coreteam@...filter.org, 
 linux-kernel@...r.kernel.org, 
 netdev@...r.kernel.org, 
 linux-arch@...r.kernel.org, 
 lkmm@...ts.linux.dev, 
 linux-kselftest@...r.kernel.org, 
 Kenjiro Nakayama <nakayamakenjiro@...il.com>
Subject: Re: [PATCH] selftests/net: call sendmmsg via udpgso_bench.sh

Kenjiro Nakayama wrote:
> Currently, sendmmsg is implemented in udpgso_bench_tx.c,
> but it is not called by any test script.
> 
> This patch adds a test for sendmmsg in udpgso_bench.sh.
> This allows for basic API testing and benchmarking
> comparisons with GSO.

The change looks fine to me, but the commit is missing your
Signed-off-by.

Also, if resubmitting, please mark [PATCH net-next v2].

> ---
>  tools/testing/selftests/net/udpgso_bench.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh
> index 640bc43452fa..88fa1d53ba2b 100755
> --- a/tools/testing/selftests/net/udpgso_bench.sh
> +++ b/tools/testing/selftests/net/udpgso_bench.sh
> @@ -92,6 +92,9 @@ run_udp() {
>  	echo "udp"
>  	run_in_netns ${args}
>  
> +	echo "udp sendmmsg"
> +	run_in_netns ${args} -m
> +
>  	echo "udp gso"
>  	run_in_netns ${args} -S 0
>  
> -- 
> 2.39.3 (Apple Git-146)
>