netdev - [PATCH net-next v6 00/10] xdp: a fistful of generic changes pt. I

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241203173733.3181246-1-aleksander.lobakin@intel.com>
Date: Tue,  3 Dec 2024 18:37:23 +0100
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	John Fastabend <john.fastabend@...il.com>,
	Andrii Nakryiko <andrii@...nel.org>
Cc: Alexander Lobakin <aleksander.lobakin@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Toke Høiland-Jørgensen <toke@...hat.com>,
	Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Magnus Karlsson <magnus.karlsson@...el.com>,
	nex.sw.ncis.osdt.itp.upstreaming@...el.com,
	bpf@...r.kernel.org,
	netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH net-next v6 00/10] xdp: a fistful of generic changes pt. I

XDP for idpf is currently 6 chapters:
* convert Rx to libeth;
* convert Tx and stats to libeth;
* generic XDP and XSk code changes (you are here);
* generic XDP and XSk code additions;
* actual XDP for idpf via new libeth_xdp;
* XSk for idpf (via ^).

Part III does the following:
* improve &xdp_buff_xsk cacheline placement;
* does some cleanups with marking read-only bpf_prog and xdp_buff
  arguments const for some generic functions;
* allows attaching already registered XDP memory model to RxQ info;
* makes system percpu page_pools valid XDP memory models;
* starts using netmems in the XDP core code (1 function);
* allows mixing pages from several page_pools within one XDP frame;
* optimizes &xdp_frame layout and removes no-more-used field.

Bullets 4-6 are the most important ones. All of them are prereqs to
libeth_xdp.

Alexander Lobakin (9):
  xsk: align &xdp_buff_xsk harder
  bpf, xdp: constify some bpf_prog * function arguments
  xdp, xsk: constify read-only arguments of some static inline helpers
  xdp: allow attaching already registered memory model to xdp_rxq_info
  xsk: allow attaching XSk pool via xdp_rxq_info_reg_mem_model()
  netmem: add a couple of page helper wrappers
  page_pool: make page_pool_put_page_bulk() handle array of netmems
  page_pool: allow mixing PPs within one bulk
  xdp: get rid of xdp_frame::mem.id

Toke Høiland-Jørgensen (1):
  xdp: register system page pool as an XDP memory model

 include/net/page_pool/types.h                 |   6 +-
 include/linux/bpf.h                           |  12 +-
 include/linux/filter.h                        |   9 +-
 include/linux/netdevice.h                     |   7 +-
 include/linux/skbuff.h                        |   2 +-
 include/net/netmem.h                          |  78 +++++++++++-
 include/net/xdp.h                             |  93 ++++++++++----
 include/net/xdp_sock_drv.h                    |  11 +-
 include/net/xsk_buff_pool.h                   |   4 +-
 .../net/ethernet/freescale/dpaa/dpaa_eth.c    |   2 +-
 drivers/net/veth.c                            |   4 +-
 kernel/bpf/cpumap.c                           |   2 +-
 kernel/bpf/devmap.c                           |   8 +-
 net/bpf/test_run.c                            |   4 +-
 net/core/dev.c                                |  20 ++-
 net/core/filter.c                             |  41 +++---
 net/core/page_pool.c                          |  79 ++++++++----
 net/core/skbuff.c                             |   2 +-
 net/core/xdp.c                                | 118 +++++++++++-------
 19 files changed, 348 insertions(+), 154 deletions(-)

---
>From v5[0]:
* split the overgrowth series into 2 parts: changes and additions
  (Jakub);
* 008: future-proof: make the touched function MP-agnostic to avoid
  double work in future;
* send to better fitting now bpf instead of netdev.

>From v4[1]:
* 12: pick RB from Toke;
* 19: drop redundant ';'s (Jakub);
* 19: fix a couple context imbalance warnings by moving __acquires() /
  __releases() to the proper place (smatch);
* no functional changes.

>From v3[2]:
* rebase on top of the latest net-next to solve conflict (Jakub);
* 09: use iterative approach instead of recursive to not blow the stack
  (Toke);
* 12: rephrase the commitmsg since the functionality changed, so that
  it's not actual anymore (Toke);
* align &xdp_buff_xsk a bit harder since its alignment degraded
  recently;
* pick RBs from Toke.

>From v2[3]:
* cover: rename the series;
* collect RBs and Acks from Maciej;
* 007: reword the commitmsg;
* 011: fix typos in the commitmsg (M);
* 012: 'ts' -> 'tsize' (M; not 'truesize' to fit into 80 cols =\);
* 016: fix the intro sentence (M);
* no functional changes.

>From v1[4]:
* rebase on top of the latest net-next;
* no other changes.

[0] https://lore.kernel.org/netdev/20241113152442.4000468-1-aleksander.lobakin@intel.com
[1] https://lore.kernel.org/netdev/20241107161026.2903044-1-aleksander.lobakin@intel.com
[2] https://lore.kernel.org/netdev/20241030165201.442301-1-aleksander.lobakin@intel.com
[3] https://lore.kernel.org/netdev/20241015145350.4077765-1-aleksander.lobakin@intel.com
[4] https://lore.kernel.org/netdev/20241009152756.3113697-1-aleksander.lobakin@intel.com
-- 
2.47.0