netdev - Re: [PATCH net-next 01/15] ice: Add E830 checksum offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7bcfc3a-9947-4689-99cd-28c064fc0f1d@intel.com>
Date: Tue, 3 Dec 2024 11:17:17 -0800
From: "Greenwalt, Paul" <paul.greenwalt@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
	<pabeni@...hat.com>, <edumazet@...gle.com>, <andrew+netdev@...n.ch>,
	<netdev@...r.kernel.org>, Alice Michael <alice.michael@...el.com>, "Eric
 Joyner" <eric.joyner@...el.com>, Alexander Lobakin
	<aleksander.lobakin@...el.com>, Pucha Himasekhar Reddy
	<himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next 01/15] ice: Add E830 checksum offload support



On 11/8/2024 3:53 PM, Greenwalt, Paul wrote:
> 
> 
> On 11/7/2024 8:14 PM, Jakub Kicinski wrote:
>> On Thu, 7 Nov 2024 17:37:41 -0800 Greenwalt, Paul wrote:
>>>> why dropping what the user requested with a warning and not just return
>>>> an error from ice_set_features()?  
>>>
>>> I took this approach of reducing the feature set to resolve the device
>>> NETIF_F_HW_CSUM and NETIF_F_ALL_TSO feature limitation, which seemed
>>> consistent with the guidance in the netdev-features documentation.
>>
>> My understanding of that guidance is that it is for "positive"
>> dependencies. Feature A requires feature B, so if feature B is
>> cleared so should the feature A. Here we have a feature conflict.
> 
> Hi Jakub,

Hi Jakub,

I'll make the requested change, and resubmit.

Thanks,
Paul

> 
> I also considered the netdevice.h comment for the ndo_fix_features hook,
> which states, 'Adjusts the requested feature flags according to
> device-specific constraints, and returns the resulting flags.'
> Additionally, since this patch introduces E830 NETIF_F_HW_CSUM support I
> reviewed the netdev_fix_features handling of NETIF_F_HW_CSUM and
> (NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM), which seemed similar—though that
> case deals with a feature conflict rather than a device conflict. These
> led me to take this approach to achieve a consistent implementation.
> 
> Thanks,
> Paul