Message-ID: <e14311a5-6461-4834-9770-e74314d11f44@quicinc.com>
Date: Tue, 3 Dec 2024 10:29:07 +0800
From: quic_zijuhu <quic_zijuhu@...cinc.com>
To: Zijun Hu <zijun_hu@...oud.com>,
        Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Philipp Zabel
	<p.zabel@...gutronix.de>,
        David Airlie <airlied@...il.com>, Simona Vetter
	<simona@...ll.ch>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
        Jean
 Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
        Martin Tuma
	<martin.tuma@...iteqautomotive.com>,
        Mauro Carvalho Chehab
	<mchehab@...nel.org>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael
 Jamet <michael.jamet@...el.com>,
        Mika Westerberg
	<mika.westerberg@...ux.intel.com>,
        Yehezkel Bernat <YehezkelShB@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski
	<brgl@...ev.pl>, Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean
	<olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni
	<pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
        Uwe Kleine-König <ukleinek@...nel.org>,
        Dan Williams
	<dan.j.williams@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Dave
 Jiang <dave.jiang@...el.com>, Ira Weiny <ira.weiny@...el.com>,
        Takashi
 Sakamoto <o-takashi@...amocchi.jp>,
        Jiri Slaby <jirislaby@...nel.org>,
        Heikki
 Krogerus <heikki.krogerus@...ux.intel.com>,
        Srinivas Kandagatla
	<srinivas.kandagatla@...aro.org>,
        Lee Duncan <lduncan@...e.com>, Chris Leech
	<cleech@...hat.com>,
        Mike Christie <michael.christie@...cle.com>,
        "James E.J.
 Bottomley" <James.Bottomley@...senPartnership.com>,
        "Martin K. Petersen"
	<martin.petersen@...cle.com>,
        Nilesh Javali <njavali@...vell.com>,
        Manish
 Rangankar <mrangankar@...vell.com>,
        <GR-QLogic-Storage-Upstream@...vell.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Jonathan Cameron
	<jonathan.cameron@...wei.com>,
        Alison Schofield <alison.schofield@...el.com>,
        Andreas Larsson <andreas@...sler.com>,
        Stuart Yoder <stuyoder@...il.com>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Jens Axboe <axboe@...nel.dk>, Sudeep Holla <sudeep.holla@....com>,
        Cristian Marussi
	<cristian.marussi@....com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>
CC: <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-hwmon@...r.kernel.org>,
        <linux-media@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-pwm@...r.kernel.org>, <nvdimm@...ts.linux.dev>,
        <linux1394-devel@...ts.sourceforge.net>,
        <linux-serial@...r.kernel.org>, <linux-sound@...r.kernel.org>,
        <open-iscsi@...glegroups.com>, <linux-scsi@...r.kernel.org>,
        <linux-cxl@...r.kernel.org>, <sparclinux@...r.kernel.org>,
        <linux-block@...r.kernel.org>, <arm-scmi@...r.kernel.org>,
        <linux-efi@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>
Subject: Re: [PATCH v2 00/32] driver core: Constify API device_find_child()
 and adapt for various existing usages

On 12/3/2024 8:33 AM, Zijun Hu wrote:
> This patch series is to constify the following API:
> struct device *device_find_child(struct device *dev, void *data,
> 		int (*match)(struct device *dev, void *data));
> To :
> struct device *device_find_child(struct device *dev, const void *data,
> 				 device_match_t match);
> typedef int (*device_match_t)(struct device *dev, const void *data);
> 
> Why to constify the API?
> 
> - Protect caller's match data @*data which is for comparison and lookup
>   and the API does not actually need to modify @*data.
> 
> - Make the API's parameters (@match)() and @data have the same type as
>   all of other device finding APIs (bus|class|driver)_find_device().
> 
> - All kinds of existing device matching functions can be directly taken
>   as the API's argument, they were exported by driver core.
> 
> How to constify the API?
> 
> - Now, no (@match)() argument of the API usages is modifying its match
>   data @*data after previous cleanup, so it is easy and safe to make its
>   parameter @data take const void * as type.
> 
> - Simplify involved codes further if it is possbile with benefits
>   brought by constifying the API.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> ---
> Changes in v2:
> - Series v1 have no code review comments and are posted a long time ago, so may ignore differences.
> - Link to v1: https://lore.kernel.org/r/20240811-const_dfc_done-
> v1-0-9d85e3f943cb@...cinc.com
> - Motivation link: https://lore.kernel.org/lkml/917359cc-a421-41dd-93f4-d28937fe2325@icloud.com
> 
> ---
> Zijun Hu (32):
>       driver core: Constify API device_find_child()
>       driver core: Introduce device_match_type() to match device with a device type
>       drm/mediatek: Adapt for constified device_find_child()
>       hwmon: Adapt for constified device_find_child()
>       media: pci: mgb4: Adapt for constified device_find_child()
>       thunderbolt: Adapt for constified device_find_child()
>       gpio: sim: Remove gpio_sim_dev_match_fwnode()
>       net: dsa: Adapt for constified device_find_child()
>       pwm: Adapt for constified device_find_child()
>       nvdimm: Adapt for constified device_find_child()
>       libnvdimm: Simplify nd_namespace_store() implementation
>       firewire: core: Adapt for constified device_find_child()
>       serial: core: Adapt for constified device_find_child()
>       usb: typec: class: Remove both cable_match() and partner_match()
>       usb: typec: class: Adapt for constified device_find_child()
>       slimbus: core: Simplify of_find_slim_device() implementation
>       slimbus: core: Constify slim_eaddr_equal()
>       slimbus: core: Adapt for constified device_find_child()
>       scsi: iscsi: Constify API iscsi_find_flashnode_sess()
>       scsi: qla4xxx: Adapt for constified iscsi_find_flashnode_sess()
>       scsi: iscsi: Adapt for constified device_find_child()
>       cxl/region: Adapt for constified device_find_child()
>       cxl/pmem: Remove match_nvdimm_bridge()
>       cxl/core/pci: Adapt for constified device_find_child()
>       cxl/test: Adapt for constified device_find_child()
>       sparc: vio: Adapt for constified device_find_child()
>       bus: fsl-mc: Adapt for constified device_find_child()
>       block: sunvdc: Adapt for constified device_find_child()
>       firmware: arm_scmi: Adapt for constified device_find_child()
>       efi: dev-path-parser: Adapt for constified device_find_child()
>       rpmsg: core: Adapt for constified device_find_child()
>       driver core: Simplify API device_find_child_by_name() implementation

sorry for that only part of this series [0/32, 11/32] were sent out due
to mail account capability limitation.

will solve the limitation and send out whole patch series as v3.

thanks (^^)

Powered by blists - more mailing lists