netdev - Re: [PATCH] USBNET: Fix ASIX USB Ethernet carrier problems.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241202192404.4713b1f9@kernel.org>
Date: Mon, 2 Dec 2024 19:24:04 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Krzysztof Hałasa <khalasa@...p.pl>
Cc: netdev <netdev@...r.kernel.org>, Oliver Neukum <oneukum@...e.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric  Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, linux-usb@...r.kernel.org,
 linux-kernel@...r.kernel.org, Jose Ignacio Tornos Martinez
 <jtornosm@...hat.com>, Ming Lei <ming.lei@...hat.com>
Subject: Re: [PATCH] USBNET: Fix ASIX USB Ethernet carrier problems.

On Wed, 27 Nov 2024 09:45:30 +0100 Krzysztof Hałasa wrote:
> To: netdev <netdev@...r.kernel.org>
> Cc: Oliver Neukum <oneukum@...e.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric  Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, linux-usb@...r.kernel.org,  linux-kernel@...r.kernel.org, Jose Ignacio Tornos Martinez <jtornosm@...hat.com>, Ming Lei <ming.lei@...hat.com>

Please add to the CC list some folks who worked on phylib and phylink
support for this driver. They will be best reviewers.

> Subject: [PATCH] USBNET: Fix ASIX USB Ethernet carrier problems.

No need to spell out USBNET in all caps. I'd rename the subject to:
  usbnet: asix: leave the carrier control to phylink

If we say it's a 'fix' we should really point at the commit which broke
things with a Fixes: tag. If your device never worked it's better to act
as if it was "support for a new device". Otherwise various semi-
-automated backport bots will suck this change in, and given the general
dependability of ASIX devices... seems risky..

> Date: Wed, 27 Nov 2024 09:45:30 +0100
> Sender: khalasa@...p.pl
> 
> Hi,

No need to say "Hi" in the commit message :)
-- 
pw-bot: cr