netdev - Re: [PATCH net-next v2] net: dsa: microchip: Make MDIO bus name unique

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMdwsN9DSk=ANXoExsyEYiFaLvN5=V4-CJerpotykLZcCHePAA@mail.gmail.com>
Date: Tue, 3 Dec 2024 06:31:45 +0100
From: Jesse Van Gavere <jesseevg@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, woojung.huh@...rochip.com, 
	UNGLinuxDriver@...rochip.com, olteanv@...il.com, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	Jesse Van Gavere <jesse.vangavere@...oteq.com>
Subject: Re: [PATCH net-next v2] net: dsa: microchip: Make MDIO bus name unique

Hello Andrew,

Op vr 29 nov 2024 om 15:54 schreef Andrew Lunn <andrew@...n.ch>:
>
> On Thu, Nov 28, 2024 at 10:25:09PM +0100, Jesse Van Gavere wrote:
> > In configurations with 2 or more DSA clusters it will fail to allocate
> > unique MDIO bus names as only the switch ID is used, fix this by using
> > a combination of the tree ID and switch ID
> >
> > Signed-off-by: Jesse Van Gavere <jesse.vangavere@...oteq.com>
> > ---
> > Changes v2: target net-next, probably an improvement rather than a true bug
>
> net-next is closed at the moment due to the merge window. Please
> repost once it opens.
>
> This change is probably O.K, but we have to be a little bit careful
> with the ABI. This name is visible in /sys/bus and udev events. In
> theory somebody could have scripts which depend on this name. I doubt
> such scripts actually exist, and if somebody reports a regression we
> will need to revert this change, and do something different. You could
> for example look at dst->index and use the two part name when it is
> not zero, one part name when it is zero.
I thought about that too and came to the same conclusion originally
that it's unlikely someone uses it, but you're right that it's better
to be safe than sorry and that sounds like a good workaround to that
potential problem, so I'll adjust that in the next version when the
merge window opens, my apologies for not sending at the correct time,
still getting the hang of contributing.

Best regards,
Jesse