netdev - Re: [PATCH net-next] tcp: Check space before adding MPTCP options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iJPTw6ANRriR1FHhSQ2aMPDP9PepSbm-+Y6S63aYZ1XLA@mail.gmail.com>
Date: Wed, 4 Dec 2024 08:35:04 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: MoYuanhao <moyuanhao3676@....com>, Matthieu Baerts <matttbe@...nel.org>, 
	Mat Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>
Cc: davem@...emloft.net, dsahern@...nel.org, kuba@...nel.org, 
	pabeni@...hat.com, horms@...nel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: Check space before adding MPTCP options

On Wed, Dec 4, 2024 at 5:07 AM MoYuanhao <moyuanhao3676@....com> wrote:
>
> Ensure enough space before adding MPTCP options in tcp_syn_options()
> Added a check to verify sufficient remaining space
> before inserting MPTCP options in SYN packets.
> This prevents issues when space is insufficient.
>
> Signed-off-by: MoYuanhao <moyuanhao3676@....com>
> ---

If this is happening, then this would be a bug, and a Fixes: tag would
be needed.

If this is not yet happening, but would happen in the future, this
patch would hide a bug.

You forgot to CC MPTCP maintainers and reviewers ?

Matthieu Baerts <matttbe@...nel.org> (maintainer:NETWORKING [MPTCP])
Mat Martineau <martineau@...nel.org> (maintainer:NETWORKING [MPTCP])
Geliang Tang <geliang@...nel.org> (reviewer:NETWORKING [MPTCP])

In my  opinion, we should pass @remaining to mptcp_syn_options()
arguments to avoid side effects.