netdev - Re: [PATCH net-next] net_sched: sch_fq: add three drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iLofU1dnwAf-4ezn08h=o82ZPCHc3QJSMUdC+5aUhRsgA@mail.gmail.com>
Date: Wed, 4 Dec 2024 08:39:27 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Cong Wang <xiyou.wangcong@...il.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Jamal Hadi Salim <jhs@...atatu.com>, 
	Victor Nogueira <victor@...atatu.com>, Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next] net_sched: sch_fq: add three drop_reason

On Wed, Dec 4, 2024 at 1:47 AM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> On Tue, Dec 03, 2024 at 09:09:29PM +0000, Eric Dumazet wrote:
> > Add three new drop_reason, more precise than generic QDISC_DROP:
> >
> > "tc -s qd" show aggregate counters, it might be more useful
> > to use drop_reason infrastructure for bug hunting.
> >
> > 1) SKB_DROP_REASON_FQ_DROP_BAND_LIMIT
> >    Whenever a packet is added while its band limit is hit.
> >    Corresponding value in "tc -s qd" is bandX_drops XXXX
> >
> > 2) SKB_DROP_REASON_FQ_DROP_HORIZON_LIMIT
> >    Whenever a packet has a timestamp too far in the future.
> >    Corresponding value in "tc -s qd" is horizon_drops XXXX
> >
> > 3) SKB_DROP_REASON_FQ_DROP_FLOW_LIMIT
> >    Whenever a flow has reached its limit.
> >    Corresponding value in "tc -s qd" is flows_plimit XXXX
> >
>
> Just a nit: maybe remove the second "DROP" in these long names?

Absolutely !

I modeled the names based on SKB_DROP_REASON_QDISC_DROP, but there is
no reason to repeat DROP.

I will send a V2 later today, thanks.