netdev - Re: [PATCHv2 net] net: sched: fix erspan_opt settings in cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z0+gAnxvkIEhmBc5@pop-os.localdomain>
Date: Tue, 3 Dec 2024 16:19:14 -0800
From: Cong Wang <xiyou.wangcong@...il.com>
To: Xin Long <lucien.xin@...il.com>
Cc: network dev <netdev@...r.kernel.org>, davem@...emloft.net,
	kuba@...nel.org, Eric Dumazet <edumazet@...gle.com>,
	Paolo Abeni <pabeni@...hat.com>,
	Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
	Davide Caratti <dcaratti@...hat.com>,
	Simon Horman <horms@...nel.org>, Shuang Li <shuali@...hat.com>
Subject: Re: [PATCHv2 net] net: sched: fix erspan_opt settings in cls_flower

On Mon, Dec 02, 2024 at 10:21:38AM -0500, Xin Long wrote:
> When matching erspan_opt in cls_flower, only the (version, dir, hwid)
> fields are relevant. However, in fl_set_erspan_opt() it initializes
> all bits of erspan_opt and its mask to 1. This inadvertently requires
> packets to match not only the (version, dir, hwid) fields but also the
> other fields that are unexpectedly set to 1.
> 
> This patch resolves the issue by ensuring that only the (version, dir,
> hwid) fields are configured in fl_set_erspan_opt(), leaving the other
> fields to 0 in erspan_opt.
> 
> Fixes: 79b1011cb33d ("net: sched: allow flower to match erspan options")
> Reported-by: Shuang Li <shuali@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Reviewed-by: Cong Wang <cong.wang@...edance.com>

Looking forward to your selftest. :)

Thanks.