netdev - Re: [PATCH net-next v1 3/7] tools/net/ynl: support decoding C arrays as enums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241203180320.0d4e5670@kernel.org>
Date: Tue, 3 Dec 2024 18:03:20 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Donald Hunter <donald.hunter@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Johannes Berg <johannes@...solutions.net>,
 linux-wireless@...r.kernel.org, donald.hunter@...hat.com
Subject: Re: [PATCH net-next v1 3/7] tools/net/ynl: support decoding C
 arrays as enums

On Tue,  3 Dec 2024 13:06:51 +0000 Donald Hunter wrote:
> Add support for translating arrays of scalars into enum names.

But not formatting hints.. ? ;) 

> Signed-off-by: Donald Hunter <donald.hunter@...il.com>
> ---
>  tools/net/ynl/lib/ynl.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py
> index 0d39a83574d5..f07a8404f71a 100644
> --- a/tools/net/ynl/lib/ynl.py
> +++ b/tools/net/ynl/lib/ynl.py
> @@ -627,6 +627,8 @@ class YnlFamily(SpecFamily):
>              decoded = self._decode_struct(attr.raw, attr_spec.struct_name)
>          elif attr_spec.sub_type:
>              decoded = attr.as_c_array(attr_spec.sub_type)
> +            if 'enum' in attr_spec:
> +                decoded = [ self._decode_enum(x, attr_spec) for x in decoded]

nit: missing space after 'decoded' or extra space before self, with
that fixed:

Acked-by: Jakub Kicinski <kuba@...nel.org>