netdev - Re: [PATCH iproute2-next, v3 2/2] iproute2: add 'ip monitor mcaddr' support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADXeF1GSgVfBZo+BmkRzCT06dSEU2CEU0Pxy=3fYbJrZipoytQ@mail.gmail.com>
Date: Wed, 4 Dec 2024 23:48:13 +0900
From: Yuyang Huang <yuyanghuang@...gle.com>
To: nicolas.dichtel@...nd.com
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	David Ahern <dsahern@...nel.org>, roopa@...ulusnetworks.com, jiri@...nulli.us, 
	stephen@...workplumber.org, jimictw@...gle.com, prohr@...gle.com, 
	liuhangbin@...il.com, andrew@...n.ch, netdev@...r.kernel.org, 
	Maciej Żenczykowski <maze@...gle.com>, 
	Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH iproute2-next, v3 2/2] iproute2: add 'ip monitor mcaddr' support

Thanks for the review feedback.

>Note that 'ip maddr' (see 'man ip-maddress') already exists. Using 'mcaddr' for
>'ip monitor' is confusing.

Please allow me to confirm the suggestion, would it be less confusing
if I use 'ip monitor maddr' here, or should I use a completely
different name?

> You could also update man/man8/ip-monitor.8

Acked, I will update the document in the next version of the patch.

Thanks,
Yuyang



On Wed, Dec 4, 2024 at 11:17 PM Nicolas Dichtel
<nicolas.dichtel@...nd.com> wrote:
>
> Le 04/12/2024 à 15:02, Yuyang Huang a écrit :
> > Enhanced the 'ip monitor' command to track changes in IPv4 and IPv6
> > multicast addresses. This update allows the command to listen for
> > events related to multicast address additions and deletions by
> > registering to the newly introduced RTNLGRP_IPV4_MCADDR and
> > RTNLGRP_IPV6_MCADDR netlink groups.
> >
> > This patch depends on the kernel patch that adds RTNLGRP_IPV4_MCADDR
> > and RTNLGRP_IPV6_MCADDR being merged first.
> >
> > Here is an example usage:
> >
> > root@...-x86-64:/# ip monitor mcaddr
>
> Note that 'ip maddr' (see 'man ip-maddress') already exists. Using 'mcaddr' for
> 'ip monitor' is confusing.
>
> You could also update man/man8/ip-monitor.8
>
>
> Regards,
> Nicolas