netdev - Re: [PATCH] net: simplify resource acquisition + ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZ6Rq+ykc4xNbGC52cgjw6uLFXZKwkeGDWk=19=nZMnvq_L+A@mail.gmail.com>
Date: Wed, 4 Dec 2024 13:37:38 +0900
From: Vincent Mailhol <mailhol.vincent@...adoo.fr>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>, 
	maxime.chevallier@...tlin.com, Madalin Bucur <madalin.bucur@....com>, 
	Sean Anderson <sean.anderson@...o.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, 
	"open list:CAN NETWORK DRIVERS" <linux-can@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: simplify resource acquisition + ioremap

Hi Rosen,

Thanks for the patch!

On Wed. 4 Dec. 2024 at 08:13, Rosen Penev <rosenp@...il.com> wrote:
> get resource + request_mem_region + ioremap can all be done by a single
> function.
>
> Replace them with devm_platform_get_and_ioremap_resource or\
> devm_platform_ioremap_resource where res is not used.
>
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>  drivers/net/can/sja1000/sja1000_platform.c | 15 ++--------

For the can driver only:

Reviewed-by: Vincent Mailhol <mailhol.vincent@...adoo.fr> # sja1000_platform.c

>  drivers/net/ethernet/freescale/fman/fman.c | 35 +++++-----------------
>  drivers/net/ethernet/lantiq_etop.c         | 25 ++--------------
>  drivers/net/mdio/mdio-octeon.c             | 25 +++-------------
>  4 files changed, 17 insertions(+), 83 deletions(-)