netdev - Re: [PATCH net-next v2 01/11] vxlan: In vxlan_rcv(), access flags through the vxlan netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d50d420-f94f-446c-b674-a532e31fd784@blackwall.org>
Date: Fri, 6 Dec 2024 11:37:53 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, Ido Schimmel <idosch@...dia.com>,
 mlxsw@...dia.com, Menglong Dong <menglong8.dong@...il.com>,
 Guillaume Nault <gnault@...hat.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Breno Leitao <leitao@...ian.org>
Subject: Re: [PATCH net-next v2 01/11] vxlan: In vxlan_rcv(), access flags
 through the vxlan netdevice

On 12/5/24 17:40, Petr Machata wrote:
> vxlan_sock.flags is constructed from vxlan_dev.cfg.flags, as the subset of
> flags (named VXLAN_F_RCV_FLAGS) that is important from the point of view of
> socket sharing. Attempts to reconfigure these flags during the vxlan netdev
> lifetime are also bounced. It is therefore immaterial whether we access the
> flags through the vxlan_dev or through the socket.
> 
> Convert the socket accesses to netdevice accesses in this separate patch to
> make the conversions that take place in the following patches more obvious.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> ---
> 
> Notes:
> CC: Menglong Dong <menglong8.dong@...il.com>
> CC: Guillaume Nault <gnault@...hat.com>
> CC: Alexander Lobakin <aleksander.lobakin@...el.com>
> CC: Breno Leitao <leitao@...ian.org>
> 
>  drivers/net/vxlan/vxlan_core.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>