netdev - Re: [PATCH net-next v2 03/11] vxlan: vxlan_rcv() callees: Drop the unparsed argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154148cf-459b-4723-8dad-d73536611557@blackwall.org>
Date: Fri, 6 Dec 2024 11:39:48 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, Ido Schimmel <idosch@...dia.com>,
 mlxsw@...dia.com, Menglong Dong <menglong8.dong@...il.com>,
 Guillaume Nault <gnault@...hat.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Breno Leitao <leitao@...ian.org>
Subject: Re: [PATCH net-next v2 03/11] vxlan: vxlan_rcv() callees: Drop the
 unparsed argument

On 12/5/24 17:40, Petr Machata wrote:
> The functions vxlan_remcsum() and vxlan_parse_gbp_hdr() take both the SKB
> and the unparsed VXLAN header. Now that unparsed adjustment is handled
> directly by vxlan_rcv(), drop this argument, and have the function derive
> it from the SKB on its own.
> 
> vxlan_parse_gpe_proto() does not take SKB, so keep the header parameter.
> However const it so that it's clear that the intention is that it does not
> get changed.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> ---
> 
> Notes:
> CC: Menglong Dong <menglong8.dong@...il.com>
> CC: Guillaume Nault <gnault@...hat.com>
> CC: Alexander Lobakin <aleksander.lobakin@...el.com>
> CC: Breno Leitao <leitao@...ian.org>
> 

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>