netdev - Re: [PATCH net-next v2 06/11] vxlan: Bump error counters for header mismatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72040f94-1834-4b4e-a308-a1cfb691e62f@blackwall.org>
Date: Fri, 6 Dec 2024 11:45:29 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, Ido Schimmel <idosch@...dia.com>,
 mlxsw@...dia.com, Menglong Dong <menglong8.dong@...il.com>,
 Guillaume Nault <gnault@...hat.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Breno Leitao <leitao@...ian.org>
Subject: Re: [PATCH net-next v2 06/11] vxlan: Bump error counters for header
 mismatches

On 12/5/24 17:40, Petr Machata wrote:
> The VXLAN driver so far has not increased the error counters for packets
> that set reserved bits. It does so for other packet errors, so do it for
> this case as well.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> ---
> 
> Notes:
> CC: Menglong Dong <menglong8.dong@...il.com>
> CC: Guillaume Nault <gnault@...hat.com>
> CC: Alexander Lobakin <aleksander.lobakin@...el.com>
> CC: Breno Leitao <leitao@...ian.org>
> 
>  drivers/net/vxlan/vxlan_core.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index f6118de81b8a..b8afdcbdf235 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -1721,6 +1721,10 @@ static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
>  		 * little more security in adding extensions to VXLAN.
>  		 */
>  		reason = SKB_DROP_REASON_VXLAN_INVALID_HDR;
> +		DEV_STATS_INC(vxlan->dev, rx_frame_errors);
> +		DEV_STATS_INC(vxlan->dev, rx_errors);
> +		vxlan_vnifilter_count(vxlan, vni, vninode,
> +				      VXLAN_VNI_STATS_RX_ERRORS, 0);
>  		goto drop;
>  	}
>  

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>