netdev - Re: [PATCH v3 iwl-next] ice: Add in/out PTP pin delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241206131635.GP2581@kernel.org>
Date: Fri, 6 Dec 2024 13:16:35 +0000
From: Simon Horman <horms@...nel.org>
To: Karol Kolacinski <karol.kolacinski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	anthony.l.nguyen@...el.com, przemyslaw.kitszel@...el.com
Subject: Re: [PATCH v3 iwl-next] ice: Add in/out PTP pin delays

On Wed, Dec 04, 2024 at 10:46:11AM +0100, Karol Kolacinski wrote:
> HW can have different input/output delays for each of the pins.
> 
> Currently, only E82X adapters have delay compensation based on TSPLL
> config and E810 adapters have constant 1 ms compensation, both cases
> only for output delays and the same one for all pins.
> 
> E825 adapters have different delays for SDP and other pins. Those
> delays are also based on direction and input delays are different than
> output ones. This is the main reason for moving delays to pin
> description structure.
> 
> Add a field in ice_ptp_pin_desc structure to reflect that. Delay values
> are based on approximate calculations of HW delays based on HW spec.
> 
> Implement external timestamp (input) delay compensation.
> 
> Remove existing definitions and wrappers for periodic output propagation
> delays.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
> ---
> V2 -> V3: rebased, renamed prop_delay to prop_delay_ns, reworded commit
>           message to be more descriptive
> V1 -> V2: removed duplicate gpio_pin variable and restored missing
>           ICE_E810_E830_SYNC_DELAY

Reviewed-by: Simon Horman <horms@...nel.org>