netdev - Re: [Patch bpf v2 0/4] bpf: a bug fix and test cases for bpf_skb_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fac7e933-a1cc-4863-9610-f5429da0d849@iogearbox.net>
Date: Fri, 6 Dec 2024 22:35:28 +0100
From: Daniel Borkmann <daniel@...earbox.net>
To: Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc: bpf@...r.kernel.org, Cong Wang <cong.wang@...edance.com>
Subject: Re: [Patch bpf v2 0/4] bpf: a bug fix and test cases for
 bpf_skb_change_tail()

Hi Cong,

On 11/29/24 2:22 AM, Cong Wang wrote:
> From: Cong Wang <cong.wang@...edance.com>
> 
> This patchset fixes a bug in bpf_skb_change_tail() helper and adds test
> cases for it, as requested by Daniel and John.
> 
> ---
> v2: added a test case for TC where offsets are positive
>      fixed a typo in 1/4 patch description
>      reduced buffer size in the sockmap test case

I ran the selftest several times but it's repeatedly failing whereas
without the series bpf tree CI seems fine. The CI fails on tc tests,
so potentially patch 4 is causing this.

Switching over to tcx APIs from libbpf might automatically address
this given the failures seem to be in 'revision unexpected' which is
likely due to legacy libbpf tc APIs detaching but not deleting the
underlying qdisc.

Thanks,
Daniel