| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202412070526.FhqWmbBo-lkp@intel.com>
Date: Sat, 7 Dec 2024 05:43:05 +0800
From: kernel test robot <lkp@...el.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
netdev@...r.kernel.org, Kuniyuki Iwashima <kuniyu@...zon.com>
Subject: Re: [PATCH v1 net-next 08/15] socket: Pass hold_net to sk_alloc().
Hi Kuniyuki,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/socket-Un-export-__sock_create/20241206-160139
base: net-next/main
patch link: https://lore.kernel.org/r/20241206075504.24153-9-kuniyu%40amazon.com
patch subject: [PATCH v1 net-next 08/15] socket: Pass hold_net to sk_alloc().
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20241207/202412070526.FhqWmbBo-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241207/202412070526.FhqWmbBo-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412070526.FhqWmbBo-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from net/iucv/af_iucv.c:16:
In file included from include/linux/filter.h:9:
In file included from include/linux/bpf.h:20:
In file included from include/linux/module.h:19:
In file included from include/linux/elf.h:6:
In file included from arch/s390/include/asm/elf.h:181:
In file included from arch/s390/include/asm/mmu_context.h:11:
In file included from arch/s390/include/asm/pgalloc.h:18:
In file included from include/linux/mm.h:2223:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> net/iucv/af_iucv.c:455:59: error: too few arguments to function call, expected 6, have 5
455 | sk = sk_alloc(&init_net, PF_IUCV, prio, &iucv_proto, kern);
| ~~~~~~~~ ^
include/net/sock.h:1745:14: note: 'sk_alloc' declared here
1745 | struct sock *sk_alloc(struct net *net, int family, gfp_t priority,
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1746 | struct proto *prot, bool kern, bool hold_net);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4 warnings and 1 error generated.
vim +455 net/iucv/af_iucv.c
eac3731bd04c713 Jennifer Hunt 2007-02-08 448
8424c284851b97e Kuniyuki Iwashima 2024-12-06 449 static struct sock *iucv_sock_alloc(struct socket *sock, int proto, gfp_t prio,
8424c284851b97e Kuniyuki Iwashima 2024-12-06 450 bool kern, bool hold_net)
eac3731bd04c713 Jennifer Hunt 2007-02-08 451 {
eac3731bd04c713 Jennifer Hunt 2007-02-08 452 struct sock *sk;
493d3971a65c921 Ursula Braun 2011-08-08 453 struct iucv_sock *iucv;
eac3731bd04c713 Jennifer Hunt 2007-02-08 454
11aa9c28b420924 Eric W. Biederman 2015-05-08 @455 sk = sk_alloc(&init_net, PF_IUCV, prio, &iucv_proto, kern);
eac3731bd04c713 Jennifer Hunt 2007-02-08 456 if (!sk)
eac3731bd04c713 Jennifer Hunt 2007-02-08 457 return NULL;
493d3971a65c921 Ursula Braun 2011-08-08 458 iucv = iucv_sk(sk);
eac3731bd04c713 Jennifer Hunt 2007-02-08 459
eac3731bd04c713 Jennifer Hunt 2007-02-08 460 sock_init_data(sock, sk);
493d3971a65c921 Ursula Braun 2011-08-08 461 INIT_LIST_HEAD(&iucv->accept_q);
493d3971a65c921 Ursula Braun 2011-08-08 462 spin_lock_init(&iucv->accept_q_lock);
493d3971a65c921 Ursula Braun 2011-08-08 463 skb_queue_head_init(&iucv->send_skb_q);
493d3971a65c921 Ursula Braun 2011-08-08 464 INIT_LIST_HEAD(&iucv->message_q.list);
493d3971a65c921 Ursula Braun 2011-08-08 465 spin_lock_init(&iucv->message_q.lock);
493d3971a65c921 Ursula Braun 2011-08-08 466 skb_queue_head_init(&iucv->backlog_skb_q);
493d3971a65c921 Ursula Braun 2011-08-08 467 iucv->send_tag = 0;
3881ac441f642d5 Ursula Braun 2011-08-08 468 atomic_set(&iucv->pendings, 0);
493d3971a65c921 Ursula Braun 2011-08-08 469 iucv->flags = 0;
3881ac441f642d5 Ursula Braun 2011-08-08 470 iucv->msglimit = 0;
ef6af7bdb9e6c14 Julian Wiedmann 2021-01-28 471 atomic_set(&iucv->skbs_in_xmit, 0);
3881ac441f642d5 Ursula Braun 2011-08-08 472 atomic_set(&iucv->msg_sent, 0);
3881ac441f642d5 Ursula Braun 2011-08-08 473 atomic_set(&iucv->msg_recv, 0);
493d3971a65c921 Ursula Braun 2011-08-08 474 iucv->path = NULL;
3881ac441f642d5 Ursula Braun 2011-08-08 475 iucv->sk_txnotify = afiucv_hs_callback_txnotify;
b5d8cf0af167f3a Kees Cook 2021-11-18 476 memset(&iucv->init, 0, sizeof(iucv->init));
3881ac441f642d5 Ursula Braun 2011-08-08 477 if (pr_iucv)
3881ac441f642d5 Ursula Braun 2011-08-08 478 iucv->transport = AF_IUCV_TRANS_IUCV;
3881ac441f642d5 Ursula Braun 2011-08-08 479 else
3881ac441f642d5 Ursula Braun 2011-08-08 480 iucv->transport = AF_IUCV_TRANS_HIPER;
eac3731bd04c713 Jennifer Hunt 2007-02-08 481
eac3731bd04c713 Jennifer Hunt 2007-02-08 482 sk->sk_destruct = iucv_sock_destruct;
eac3731bd04c713 Jennifer Hunt 2007-02-08 483 sk->sk_sndtimeo = IUCV_CONN_TIMEOUT;
eac3731bd04c713 Jennifer Hunt 2007-02-08 484
eac3731bd04c713 Jennifer Hunt 2007-02-08 485 sock_reset_flag(sk, SOCK_ZAPPED);
eac3731bd04c713 Jennifer Hunt 2007-02-08 486
eac3731bd04c713 Jennifer Hunt 2007-02-08 487 sk->sk_protocol = proto;
eac3731bd04c713 Jennifer Hunt 2007-02-08 488 sk->sk_state = IUCV_OPEN;
eac3731bd04c713 Jennifer Hunt 2007-02-08 489
eac3731bd04c713 Jennifer Hunt 2007-02-08 490 iucv_sock_link(&iucv_sk_list, sk);
eac3731bd04c713 Jennifer Hunt 2007-02-08 491 return sk;
eac3731bd04c713 Jennifer Hunt 2007-02-08 492 }
eac3731bd04c713 Jennifer Hunt 2007-02-08 493
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists