netdev - Re: [PATCH v6 09/28] sfc: request cxl ram resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nPTL0OiN-aCaob714yh91za=uXyOi_MnGKUCL4p5EOW4A@mail.gmail.com>
Date: Fri, 6 Dec 2024 09:58:33 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: alejandro.lucero-palau@....com
Cc: linux-cxl@...r.kernel.org, netdev@...r.kernel.org, 
	dan.j.williams@...el.com, martin.habets@...inx.com, edward.cree@....com, 
	davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, 
	dave.jiang@...el.com, Alejandro Lucero <alucerop@....com>
Subject: Re: [PATCH v6 09/28] sfc: request cxl ram resource

On Mon, Dec 2, 2024 at 10:44 PM <alejandro.lucero-palau@....com> wrote:
>
> From: Alejandro Lucero <alucerop@....com>
>
> Use cxl accessor for obtaining the ram resource the device advertises.
>
> Signed-off-by: Alejandro Lucero <alucerop@....com>
> ---
>  drivers/net/ethernet/sfc/efx_cxl.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/ethernet/sfc/efx_cxl.c b/drivers/net/ethernet/sfc/efx_cxl.c
> index 44e1061feba1..76ce4c2e587b 100644
> --- a/drivers/net/ethernet/sfc/efx_cxl.c
> +++ b/drivers/net/ethernet/sfc/efx_cxl.c
> @@ -84,6 +84,12 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>                 goto err2;
>         }
>
> +       rc = cxl_request_resource(cxl->cxlds, CXL_RES_RAM);
> +       if (rc) {
> +               pci_err(pci_dev, "CXL request resource failed");
In case of failure, cxl_request_resource() logs an error message.
Hence do you really need this duplicate log?
> +               goto err2;
> +       }
> +
>         probe_data->cxl = cxl;
>
>         return 0;
> @@ -98,6 +104,7 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>  void efx_cxl_exit(struct efx_probe_data *probe_data)
>  {
>         if (probe_data->cxl) {
> +               cxl_release_resource(probe_data->cxl->cxlds, CXL_RES_RAM);
>                 kfree(probe_data->cxl->cxlds);
>                 kfree(probe_data->cxl);
>         }
> --
> 2.17.1
>
>


-- 
Regards,
Kalesh A P

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)