netdev - Re: [PATCH] net: dsa: microchip: KSZ9896 register regmap alignment to 32 bit boundaries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241206172435.23d9091c@kernel.org>
Date: Fri, 6 Dec 2024 17:24:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jesse Van Gavere <jesseevg@...il.com>
Cc: netdev@...r.kernel.org, woojung.huh@...rochip.com,
 UNGLinuxDriver@...rochip.com, andrew@...n.ch, olteanv@...il.com, Jesse Van
 Gavere <jesse.vangavere@...oteq.com>, Tristram.Ha@...rochip.com
Subject: Re: [PATCH] net: dsa: microchip: KSZ9896 register regmap alignment
 to 32 bit boundaries

On Fri, 6 Dec 2024 23:12:56 +0100 Jesse Van Gavere wrote:
> A quick ping on this, how do I best proceed here?
> Do I keep the original commit and take in account the feedback for the
> commit message or should I e.g. like Tristram recommended just modify
> it to 2 regmap reg ranges for these PHY registers?

I don't have enough practical regmap experience to understand Tristram
suggestion, TBH. Is he saying to collapse multiple ranges into one by
extending it to register that are currently not used? Or to somehow
ignore high bits? Rhetorical question, see below..

> In that case I might just as well modify this commit to make this
> modification for all the existing regmap reg range arrays defined.
> (There's probably also something to say about enforcing these ranges
> across more chips but that's a bit outside the scope of what I'm
> trying to do here)

Whatever makes the changes easier to review. If the combined commit is
small (per stable rules) and easy to review follow the feedback. If
it's easier to review the fix and then cleanup separately - separate.