netdev - Re: [PATCH v3 net-next] net/mlx5e: Report rx_discards_phy via rx_fifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALOAHbCFm6aGm2ZpEBKR2j4cCy8fU0STjmYFOm-fhsH7xmwFUw@mail.gmail.com>
Date: Sun, 8 Dec 2024 14:01:17 +0800
From: Yafang Shao <laoar.shao@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: saeedm@...dia.com, tariqt@...dia.com, leon@...nel.org, gal@...dia.com, 
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org, 
	Tariq Toukan <ttoukan.linux@...il.com>
Subject: Re: [PATCH v3 net-next] net/mlx5e: Report rx_discards_phy via rx_fifo_errors

On Sun, Dec 8, 2024 at 9:38 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri,  6 Dec 2024 17:03:28 +0800 Yafang Shao wrote:
> > We observed a high number of rx_discards_phy events on some servers when
> > running `ethtool -S`. However, this important counter is not currently
> > reflected in the /proc/net/dev statistics file, making it challenging to
> > monitor effectively.
> >
> > Since rx_fifo_errors represents receive FIFO errors on this network
> > deivice, it makes sense to include rx_discards_phy in this counter to
> > enhance monitoring visibility. This change will help administrators track
> > these events more effectively through standard interfaces.
>
> It's not a standard if there is no definition applicable across vendors.
> Count it as generic rx_dropped.

Thank you for your suggestion. I'm okay with counting it as generic
rx_dropped as long as we have a metric to track it.
I will send a new version.

--
Regards
Yafang