netdev - Re: [PATCH net-next] l2tp: Handle eth stats using NETDEV_PCPU_STAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1bpuGs5Y8kmY5hu@debian>
Date: Mon, 9 Dec 2024 13:59:36 +0100
From: Guillaume Nault <gnault@...hat.com>
To: James Chapman <jchapman@...alix.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	tparkin@...alix.com, aleksander.lobakin@...el.com,
	ricardo@...liere.net, mail@...id-bauer.net
Subject: Re: [PATCH net-next] l2tp: Handle eth stats using
 NETDEV_PCPU_STAT_DSTATS.

On Mon, Dec 09, 2024 at 11:46:07AM +0000, James Chapman wrote:
> l2tp_eth uses the TSTATS infrastructure (dev_sw_netstats_*()) for RX
> and TX packet counters and DEV_STATS_INC for dropped counters.
> 
> Consolidate that using the DSTATS infrastructure, which can
> handle both packet counters and packet drops. Statistics that don't
> fit DSTATS are still updated atomically with DEV_STATS_INC().

Reviewed-by: Guillaume Nault <gnault@...hat.com>

Thanks!