netdev - Re: [PATCH net] Documentation: networking: Add a caveat to nexthop_compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <688a8d28-fe32-4afd-af0a-5fdbc317e63e@kernel.org>
Date: Mon, 9 Dec 2024 09:26:55 -0700
From: David Ahern <dsahern@...nel.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>, mlxsw@...dia.com
Subject: Re: [PATCH net] Documentation: networking: Add a caveat to
 nexthop_compat_mode sysctl

On 12/9/24 4:05 AM, Petr Machata wrote:
> net.ipv4.nexthop_compat_mode was added when nexthop objects were added to
> provide the view of nexthop objects through the usual lens of the route
> UAPI. As nexthop objects evolved, the information provided through this
> lens became incomplete. For example, details of resilient nexthop groups
> are obviously omitted.
> 
> Now that 16-bit nexthop group weights are a thing, the 8-bit UAPI cannot
> convey the >8-bit weight accurately. Instead of inventing workarounds for
> an obsolete interface, just document the expectations of inaccuracy.
> 
> Fixes: b72a6a7ab957 ("net: nexthop: Increase weight to u16")
> Signed-off-by: Petr Machata <petrm@...dia.com>
> ---
>  Documentation/networking/ip-sysctl.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>