netdev - Re: KSZ8795 fixes for v5.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <kuvnl6z64ldmksnlfdcsfl5unlfdy3sryajjmvrtyenadwktqq@6fhjs3blojkl>
Date: Mon, 9 Dec 2024 19:45:11 +0100
From: Jörg Sommer <joerg@...so.de>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org
Subject: Re: KSZ8795 fixes for v5.15

Andrew Lunn schrieb am Sa 07. Dez, 21:58 (+0100):
> On Sat, Dec 07, 2024 at 09:44:46AM +0100, Jörg Sommer wrote:
> > Hi,
> > 
> > it's me again with the KSZ8795 connected to TI_DAVINCI_EMAC. It works on
> > v5.10.227 and now, I try to get this working on v5.15 (and then later
> > versions). I found this patch [1] in the Microchip forum [2]. Someone put it
> > together to make this chip work with v5.15. I applies fine on v5.15.173 and
> > gets me to a point where the kernel detects the chip during boot. (It still
> > doesn't work, but it's better with this patch than without.)
> > 
> > [1] https://forum.microchip.com/sfc/servlet.shepherd/document/download/0693l00000XiIt9AAF
> > [2] https://forum.microchip.com/s/topic/a5C3l000000MfQkEAK/t388621
> > 
> > The driver code was restructured in 9f73e1 which contained some mistakes.
> > These were fixed later with 4bdf79 (which is part of the patch), but was not
> > backported to v5.15 as a grep shows:
> > 
> > $ git grep STATIC_MAC_TABLE_OVERRIDE'.*2[26]' v5.15.173
> > v5.15.173:drivers/net/dsa/microchip/ksz8795.c:55:       [STATIC_MAC_TABLE_OVERRIDE]     = BIT(26),
> > $ git grep STATIC_MAC_TABLE_OVERRIDE'.*2[26]' v6.6.62
> > v6.6.62:drivers/net/dsa/microchip/ksz_common.c:334:     [STATIC_MAC_TABLE_OVERRIDE]     = BIT(22),
> > 
> > Can someone review this patch and apply it to the v5.15 branch?
> 
> Hi Jörg
> 
> Please see:
> 
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> 
> Option 2.

I didn't know everyone can request a backport. But, unfortunately, neither
4bdf79d686b49ac49373b36466acfb93972c7d7c from main, nor
ce3ec3fc64e0e0f4d148cccba4e31246d50ec910 from v6.1 can be cherry-picked
without big conflicts.

I think I have to use Option 3 and send a new commit.


Kind regards, Jörg

-- 
Außerdem teilt sich die Welt nicht in gute Menschen und böse, wir haben
alle sowohl eine helle als auch eine dunkle Seite in uns. Es kommt darauf
an, welche Seite wir für unser Handeln aussuchen. Das macht uns wirklich
aus.                             (Harry Potter und der Orden des Phönix)

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)