netdev - Re: [PATCH v2 1/2][next] UAPI: ethtool: Use __struct_group() in struct ethtool_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20241209131032.6af473f4@kernel.org>
Date: Mon, 9 Dec 2024 13:10:32 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Christopher Ferris <cferris@...gle.com>
Cc: Nick Desaulniers <ndesaulniers@...gle.com>, Kees Cook <kees@...nel.org>,
 "Gustavo A. R. Silva" <gustavo@...eddedor.com>, "Gustavo A. R. Silva"
 <gustavoars@...nel.org>, Michael Chan <michael.chan@...adcom.com>, Andrew
 Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Potnuri
 Bharat Teja <bharat@...lsio.com>, Christian Benvenuti <benve@...co.com>,
 Satish Kharat <satishkh@...co.com>, Manish Chopra <manishc@...vell.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org, android-llvm-dev@...gle.com
Subject: Re: [PATCH v2 1/2][next] UAPI: ethtool: Use __struct_group() in
 struct ethtool_link_settings

On Mon, 9 Dec 2024 12:59:40 -0800 Christopher Ferris wrote:
> It looks like the way this was fixed in the ethtool.h uapi header was to
> revert the usage of __struct_group. Should something similar happen for
> pkt_cls.h? Or would it be easier to simply remove the usage of the TAG in
> the _struct_group macro?

Just to state it explicitly - are you running into a compilation issue
with existing user space after updating pkt_cls.h?