netdev - Re: [PATCH net-next v2 2/2] net/smc: support ipv4 mapped ipv6 addr client for smc-r v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241209104647.5c36c429.pasic@linux.ibm.com>
Date: Mon, 9 Dec 2024 10:46:47 +0100
From: Halil Pasic <pasic@...ux.ibm.com>
To: Wenjia Zhang <wenjia@...ux.ibm.com>
Cc: Guangguan Wang <guangguan.wang@...ux.alibaba.com>, jaka@...ux.ibm.com,
        alibuda@...ux.alibaba.com, tonylu@...ux.alibaba.com,
        guwen@...ux.alibaba.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
        linux-rdma@...r.kernel.org, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Dust Li
 <dust.li@...ux.alibaba.com>,
        Halil Pasic <pasic@...ux.ibm.com>
Subject: Re: [PATCH net-next v2 2/2] net/smc: support ipv4 mapped ipv6 addr
 client for smc-r v2

On Mon, 9 Dec 2024 09:49:23 +0100
Wenjia Zhang <wenjia@...ux.ibm.com> wrote:

> > Otherwise, the code below is reasonable.
> >        if (!(ini->smcr_version & SMC_V2) ||
> > +#if IS_ENABLED(CONFIG_IPV6)
> > +        (smc->clcsock->sk->sk_family == AF_INET6 &&
> > +         !ipv6_addr_v4mapped(&smc->clcsock->sk->sk_v6_rcv_saddr)) ||
> > +#endif
> >            !smc_clc_ueid_count() ||
> >            smc_find_rdma_device(smc, ini))
> >            ini->smcr_version &= ~SMC_V2;
> >   
> Ok, I got your point, a socket with an address family other than AF_INET 
> and AF_INET6 is already pre-filtered, so that such extra condition 
> checking for the smc->clcsock->sk->sk_family != AF_INET is not 
> necessary, right?
> 
> Would you like to send a new version? And feel free to use this in the 
> new version:
> 
> Reviewed-by: Wenjia Zhang <wenjia@...ux.ibm.com>

I believe we would like to have a v3 here. Also I'm not sure
checking on saddr is sufficient, but I didn't do my research on
that question yet.

Regards,
Halil