netdev - Re: [PATCH v7] xfrm: add SA information to the offloaded packet when if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1gJyHRCmreRcx8h@gauss3.secunet.de>
Date: Tue, 10 Dec 2024 10:28:40 +0100
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Feng Wang <wangfe@...gle.com>
CC: <netdev@...r.kernel.org>, <antony.antony@...unet.com>,
	<leonro@...dia.com>, <pabeni@...hat.com>
Subject: Re: [PATCH v7] xfrm: add SA information to the offloaded packet when
 if_id is set

On Mon, Dec 09, 2024 at 08:28:12PM +0000, Feng Wang wrote:
>  
> +static int nsim_ipsec_add_policy(struct xfrm_policy *policy,
> +				 struct netlink_ext_ack *extack)
> +{
> +	return 0;
> +}

Returning 0 here is apparently wrong. If you want to add packet offload
support to nsim, you need to implement everything what a real packet
offload driver plus HW will do.

> @@ -728,7 +730,27 @@ int xfrm_output(struct sock *sk, struct sk_buff *skb)
>  			kfree_skb(skb);
>  			return -EHOSTUNREACH;
>  		}
> +		if (x->if_id) {
> +			sp = secpath_set(skb);

secpath_set is expensive, this will slow down crypto offload
for no reason. This has to go to some driver specific
codepath.