netdev - Re: [PATCH v1 net-next 04/15] af_unix: Remove redundant SEND_SHUTDOWN check in unix_stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5076560-07c1-4fc8-93f8-df19b3568927@redhat.com>
Date: Tue, 10 Dec 2024 12:48:53 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>
Cc: Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 04/15] af_unix: Remove redundant SEND_SHUTDOWN
 check in unix_stream_sendmsg().

On 12/6/24 06:25, Kuniyuki Iwashima wrote:
> sock_alloc_send_pskb() in the following while loop checks if
> SEND_SHUTDOWN is set to sk->sk_shutdown.
> 
> Let's remove the redundant check in unix_stream_sendmsg().

If socket error is != 0, the user shutsdown for write and than does a
(stream) sendmsg, AFAICS prior to this patch it will get a piper error,
but now it will get the socket error.

I'm unsure if we should preserve the old behavior, weird applications
could rely on that ?!? usually there are more weird applications around
that what I suspect.

At least the behavior change should be noted. If it does not impact too
much the series and drop reasons addition, perhaps just drop this
cleanup? (Assuming my initial statement is correct).

Thanks!

Paolo