netdev - Re: [PATCH net 2/4] net: dsa: mv88e6xxx: Give chips more time to activate their PPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9c93b21-71e4-431d-9ab2-e73d47d12dd8@redhat.com>
Date: Tue, 10 Dec 2024 13:10:57 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Tobias Waldekranz <tobias@...dekranz.com>, Andrew Lunn <andrew@...n.ch>
Cc: davem@...emloft.net, kuba@...nel.org, f.fainelli@...il.com,
 olteanv@...il.com, netdev@...r.kernel.org, linux@...linux.org.uk,
 chris.packham@...iedtelesis.co.nz
Subject: Re: [PATCH net 2/4] net: dsa: mv88e6xxx: Give chips more time to
 activate their PPUs

On 12/6/24 14:39, Tobias Waldekranz wrote:
> On fre, dec 06, 2024 at 14:18, Andrew Lunn <andrew@...n.ch> wrote:
>> On Fri, Dec 06, 2024 at 02:07:34PM +0100, Tobias Waldekranz wrote:
>>> +
>>> +	if (err) {
>>> +		dev_err(chip->dev, "PPU did not come online: %d\n", err);
>>> +		return err;
>>> +	}
>>> +
>>> +	if (i)
>>> +		dev_warn(chip->dev,
>>> +			 "PPU was slow to come online, retried %d times\n", i);
>>
>> dev_dbg()? Does the user care if it took longer than one loop
>> iteration?
> 
> My resoning was: While it does seem fine that the device takes this long
> to initialize, if it turns out that this is an indication of some bigger
> issue, it might be good to have it recorded in the log.

What about dev_info()? Warn in the log message tend to be interpreted in
pretty drastic ways.

Thanks,

Paolo