netdev - Re: Re: [PATCH net-next 1/4] vsock/test: Use NSEC_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241210144631.20573-2-leonardi@redhat.com>
Date: Tue, 10 Dec 2024 15:46:32 +0100
From: Luigi Leonardi <leonardi@...hat.com>
To: leonardi@...hat.com
Cc: mhal@...x.co,
	netdev@...r.kernel.org,
	sgarzare@...hat.com
Subject: Re: Re: [PATCH net-next 1/4] vsock/test: Use NSEC_PER_SEC

> > Series adds tests for recently fixed memory leaks[1]:
> >
> > d7b0ff5a8667 ("virtio/vsock: Fix accept_queue memory leak")
> > fbf7085b3ad1 ("vsock: Fix sk_error_queue memory leak")
> > 60cf6206a1f5 ("virtio/vsock: Improve MSG_ZEROCOPY error handling")
> >
> > First patch is a non-functional preparatory cleanup.
> >
> > I initially considered triggering (and parsing) a kmemleak scan after each
> > test, but ultimately concluded that the slowdown and the required
> > privileges would be too much.
> >
> > [1]: https://lore.kernel.org/netdev/20241107-vsock-mem-leaks-v2-0-4e21bfcfc818@rbox.co/
> >
> > Signed-off-by: Michal Luczaj <mhal@...x.co>
> > ---
> > Michal Luczaj (4):
> >       vsock/test: Use NSEC_PER_SEC
> >       vsock/test: Add test for accept_queue memory leak
> >       vsock/test: Add test for sk_error_queue memory leak
> >       vsock/test: Add test for MSG_ZEROCOPY completion memory leak
> >
> >  tools/testing/vsock/vsock_test.c | 159 ++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 157 insertions(+), 2 deletions(-)
> > ---
> > base-commit: 51db5c8943001186be0b5b02456e7d03b3be1f12
> > change-id: 20241203-test-vsock-leaks-38f9559f5636
> >
> > Best regards,
> > --
> > Michal Luczaj <mhal@...x.co>
>
> Thanks!
>
> Reviewed-by: Luigi Leonardi <leonardi@...hat.com>

For maintainers:

I made a mess with git send-email, this R-b is only for patch 1, I haven't
checked the others yet.

Luigi