netdev - Re: [PATCH 09/16] net-next/yunsilicon: Init net device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cd0f6da-6075-404a-a38d-71ee41846031@oss.qualcomm.com>
Date: Mon, 9 Dec 2024 16:18:44 -0800
From: Jeff Johnson <jeff.johnson@....qualcomm.com>
To: Tian Xin <tianx@...silicon.com>, netdev@...r.kernel.org,
        davem@...emloft.net
Cc: weihg@...silicon.com
Subject: Re: [PATCH 09/16] net-next/yunsilicon: Init net device

On 12/8/24 23:10, Tian Xin wrote:
...
> @@ -133,3 +462,6 @@ static __exit void xsc_net_driver_exit(void)
>  
>  module_init(xsc_net_driver_init);
>  module_exit(xsc_net_driver_exit);
> +
> +MODULE_LICENSE("GPL");

Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning with make W=1. Please add a MODULE_DESCRIPTION()
to avoid this warning.

My mechanism to flag these looks for patches with a MODULE_LICENSE()
but not a MODULE_DESCRIPTION(). Since this is patching existing code,
if there is already a MODULE_DESCRIPTION() present, please ignore this
advice.

/jeff