netdev - Re: [PATCH net-next 1/4] vsock/test: Use NSEC_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xob4ybc3qfgmveslb2ocj5ikyepwcrpl5pfb536wiqib3hzn6e@co4fz3zbdes2>
Date: Tue, 10 Dec 2024 17:21:38 +0100
From: Stefano Garzarella <sgarzare@...hat.com>
To: Michal Luczaj <mhal@...x.co>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/4] vsock/test: Use NSEC_PER_SEC

On Fri, Dec 06, 2024 at 07:34:51PM +0100, Michal Luczaj wrote:
>Replace 1000000000ULL with NSEC_PER_SEC.
>
>No functional change intended.
>
>Signed-off-by: Michal Luczaj <mhal@...x.co>
>---
> tools/testing/vsock/vsock_test.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>

>
>diff --git a/tools/testing/vsock/vsock_test.c b/tools/testing/vsock/vsock_test.c
>index 48f17641ca504316d1199926149c9bd62eb2921d..38fd8d96eb83ef1bd45728cfaac6adb3c1e07cfe 100644
>--- a/tools/testing/vsock/vsock_test.c
>+++ b/tools/testing/vsock/vsock_test.c
>@@ -22,6 +22,7 @@
> #include <signal.h>
> #include <sys/ioctl.h>
> #include <linux/sockios.h>
>+#include <linux/time64.h>
>
> #include "vsock_test_zerocopy.h"
> #include "timeout.h"
>@@ -559,7 +560,7 @@ static time_t current_nsec(void)
> 		exit(EXIT_FAILURE);
> 	}
>
>-	return (ts.tv_sec * 1000000000ULL) + ts.tv_nsec;
>+	return (ts.tv_sec * NSEC_PER_SEC) + ts.tv_nsec;
> }
>
> #define RCVTIMEO_TIMEOUT_SEC 1
>@@ -599,7 +600,7 @@ static void test_seqpacket_timeout_client(const struct test_opts *opts)
> 	}
>
> 	read_overhead_ns = current_nsec() - read_enter_ns -
>-			1000000000ULL * RCVTIMEO_TIMEOUT_SEC;
>+			   NSEC_PER_SEC * RCVTIMEO_TIMEOUT_SEC;
>
> 	if (read_overhead_ns > READ_OVERHEAD_NSEC) {
> 		fprintf(stderr,
>
>-- 
>2.47.1
>