netdev - Re: [PATCH net-next v8 06/17] net: page pool: add helper creating area from pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9eea9b2f-3687-42e7-ade6-a99772390f98@gmail.com>
Date: Tue, 10 Dec 2024 03:58:00 +0000
From: Pavel Begunkov <asml.silence@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, David Wei <dw@...idwei.uk>
Cc: io-uring@...r.kernel.org, netdev@...r.kernel.org,
 Jens Axboe <axboe@...nel.dk>, Paolo Abeni <pabeni@...hat.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jesper Dangaard Brouer <hawk@...nel.org>, David Ahern <dsahern@...nel.org>,
 Mina Almasry <almasrymina@...gle.com>,
 Stanislav Fomichev <stfomichev@...il.com>, Joe Damato <jdamato@...tly.com>,
 Pedro Tammela <pctammela@...atatu.com>
Subject: Re: [PATCH net-next v8 06/17] net: page pool: add helper creating
 area from pages

On 12/10/24 03:29, Jakub Kicinski wrote:
> On Wed,  4 Dec 2024 09:21:45 -0800 David Wei wrote:
>> From: Pavel Begunkov <asml.silence@...il.com>
>>
>> Add a helper that takes an array of pages and initialises passed in
>> memory provider's area with them, where each net_iov takes one page.
>> It's also responsible for setting up dma mappings.
>>
>> We keep it in page_pool.c not to leak netmem details to outside
>> providers like io_uring, which don't have access to netmem_priv.h
>> and other private helpers.
> 
> User space will likely give us hugepages. Feels a bit wasteful to map
> and manage them 4k at a time. But okay, we can optimize this later.

I killed the api and moved bits of it out of net/. If multiple pools
are expected, dma mapping and pp assigning need to happen at different
points in time, and having such api doesn't make sense.

-- 
Pavel Begunkov