netdev - Re: [PATCH net v2] net: renesas: rswitch: fix initial MPIC register setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1kuB1Ac225G8HkY@mev-dev.igk.intel.com>
Date: Wed, 11 Dec 2024 07:15:35 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Nikita Yushchenko <nikita.yoush@...entembedded.com>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Andrew Lunn <andrew@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Michael Dege <michael.dege@...esas.com>,
	Christian Mardmoeller <christian.mardmoeller@...esas.com>,
	Dennis Ostermann <dennis.ostermann@...esas.com>
Subject: Re: [PATCH net v2] net: renesas: rswitch: fix initial MPIC register
 setting

On Wed, Dec 11, 2024 at 10:30:12AM +0500, Nikita Yushchenko wrote:
> MPIC.PIS must be set per phy interface type.
> MPIC.LSC must be set per speed.
> 
> Do that strictly per datasheet, instead of hardcoding MPIC.PIS to GMII.
> 
> Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> Signed-off-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>
> ---
> v1: https://lore.kernel.org/netdev/20241209075951.163924-1-nikita.yoush@cogentembedded.com/
> changes: regenerate against top of net tree (commit 3dd002f20098 "net:
>          renesas: rswitch: handle stop vs interrupt race") to ensure it
>          applies cleanly
> ---
>  drivers/net/ethernet/renesas/rswitch.c | 27 ++++++++++++++++++++------
>  drivers/net/ethernet/renesas/rswitch.h | 14 ++++++-------
>  2 files changed, 28 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> index 6ec714789573..dbbbf024e7ab 100644
> --- a/drivers/net/ethernet/renesas/rswitch.c
> +++ b/drivers/net/ethernet/renesas/rswitch.c
> @@ -1116,25 +1116,40 @@ static int rswitch_etha_wait_link_verification(struct rswitch_etha *etha)
>  
>  static void rswitch_rmac_setting(struct rswitch_etha *etha, const u8 *mac)
>  {
> -	u32 val;
> +	u32 pis, lsc;
>  
>  	rswitch_etha_write_mac_address(etha, mac);
>  
> +	switch (etha->phy_interface) {
> +	case PHY_INTERFACE_MODE_SGMII:
> +		pis = MPIC_PIS_GMII;
> +		break;
> +	case PHY_INTERFACE_MODE_USXGMII:
> +	case PHY_INTERFACE_MODE_5GBASER:
> +		pis = MPIC_PIS_XGMII;
> +		break;
> +	default:
> +		pis = FIELD_GET(MPIC_PIS, ioread32(etha->addr + MPIC));
> +		break;
> +	}
> +
>  	switch (etha->speed) {
>  	case 100:
> -		val = MPIC_LSC_100M;
> +		lsc = MPIC_LSC_100M;
>  		break;
>  	case 1000:
> -		val = MPIC_LSC_1G;
> +		lsc = MPIC_LSC_1G;
>  		break;
>  	case 2500:
> -		val = MPIC_LSC_2_5G;
> +		lsc = MPIC_LSC_2_5G;
>  		break;
>  	default:
> -		return;
> +		lsc = FIELD_GET(MPIC_LSC, ioread32(etha->addr + MPIC));
> +		break;
>  	}
>  
> -	iowrite32(MPIC_PIS_GMII | val, etha->addr + MPIC);
> +	rswitch_modify(etha->addr, MPIC, MPIC_PIS | MPIC_LSC,
> +		       FIELD_PREP(MPIC_PIS, pis) | FIELD_PREP(MPIC_LSC, lsc));
>  }
>  
>  static void rswitch_etha_enable_mii(struct rswitch_etha *etha)
> diff --git a/drivers/net/ethernet/renesas/rswitch.h b/drivers/net/ethernet/renesas/rswitch.h
> index 72e3ff596d31..e020800dcc57 100644
> --- a/drivers/net/ethernet/renesas/rswitch.h
> +++ b/drivers/net/ethernet/renesas/rswitch.h
> @@ -724,13 +724,13 @@ enum rswitch_etha_mode {
>  
>  #define EAVCC_VEM_SC_TAG	(0x3 << 16)
>  
> -#define MPIC_PIS_MII		0x00
> -#define MPIC_PIS_GMII		0x02
> -#define MPIC_PIS_XGMII		0x04
> -#define MPIC_LSC_SHIFT		3
> -#define MPIC_LSC_100M		(1 << MPIC_LSC_SHIFT)
> -#define MPIC_LSC_1G		(2 << MPIC_LSC_SHIFT)
> -#define MPIC_LSC_2_5G		(3 << MPIC_LSC_SHIFT)
> +#define MPIC_PIS		GENMASK(2, 0)
> +#define MPIC_PIS_GMII		2
> +#define MPIC_PIS_XGMII		4
> +#define MPIC_LSC		GENMASK(5, 3)
> +#define MPIC_LSC_100M		1
> +#define MPIC_LSC_1G		2
> +#define MPIC_LSC_2_5G		3
>  
>  #define MDIO_READ_C45		0x03
>  #define MDIO_WRITE_C45		0x01
> -- 
> 2.39.5

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>