netdev - Re: [PATCH net 4/5] team: Fix initial vlan_feature set in __team_compute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edd28733-d127-4d92-8d7b-bc111347cd3d@blackwall.org>
Date: Wed, 11 Dec 2024 09:47:35 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org
Cc: bpf@...r.kernel.org, mkubecek@...e.cz, Ido Schimmel <idosch@...sch.org>,
 Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net 4/5] team: Fix initial vlan_feature set in
 __team_compute_features

On 12/10/24 16:12, Daniel Borkmann wrote:
> Similarly as with bonding, fix the calculation of vlan_features to reuse
> netdev_base_features() in order derive the set in the same way as
> ndo_fix_features before iterating through the slave devices to refine the
> feature set.
> 
> Fixes: 3625920b62c3 ("teaming: fix vlan_features computing")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Cc: Nikolay Aleksandrov <razor@...ckwall.org>
> Cc: Ido Schimmel <idosch@...sch.org>
> Cc: Jiri Pirko <jiri@...dia.com>
> ---
>  drivers/net/team/team_core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c
> index 1df062c67640..306416fc1db0 100644
> --- a/drivers/net/team/team_core.c
> +++ b/drivers/net/team/team_core.c
> @@ -991,13 +991,14 @@ static void team_port_disable(struct team *team,
>  static void __team_compute_features(struct team *team)
>  {
>  	struct team_port *port;
> -	netdev_features_t vlan_features = TEAM_VLAN_FEATURES &
> -					  NETIF_F_ALL_FOR_ALL;
> +	netdev_features_t vlan_features = TEAM_VLAN_FEATURES;
>  	netdev_features_t enc_features  = TEAM_ENC_FEATURES;
>  	unsigned short max_hard_header_len = ETH_HLEN;
>  	unsigned int dst_release_flag = IFF_XMIT_DST_RELEASE |
>  					IFF_XMIT_DST_RELEASE_PERM;
>  
> +	vlan_features = netdev_base_features(vlan_features);
> +
>  	rcu_read_lock();
>  	list_for_each_entry_rcu(port, &team->port_list, list) {
>  		vlan_features = netdev_increment_features(vlan_features,

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>