netdev - Re: [PATCH net-next 5/5] ionic: add support for QSFP_PLUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1llmJmTWBrCwjTK@shredder>
Date: Wed, 11 Dec 2024 12:12:40 +0200
From: Ido Schimmel <idosch@...sch.org>
To: Shannon Nelson <shannon.nelson@....com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch,
	jacob.e.keller@...el.com, brett.creeley@....com
Subject: Re: [PATCH net-next 5/5] ionic: add support for QSFP_PLUS_CMIS

On Tue, Dec 10, 2024 at 10:30:45AM -0800, Shannon Nelson wrote:
> Teach the driver to recognize and decode the sfp pid
> SFF8024_ID_QSFP_PLUS_CMIS correctly.
> 
> Signed-off-by: Shannon Nelson <shannon.nelson@....com>
> ---
>  drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> index 272317048cb9..720092b1633a 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> @@ -968,6 +968,7 @@ static int ionic_get_module_info(struct net_device *netdev,
>  		break;
>  	case SFF8024_ID_QSFP_8436_8636:
>  	case SFF8024_ID_QSFP28_8636:
> +	case SFF8024_ID_QSFP_PLUS_CMIS:
>  		modinfo->type = ETH_MODULE_SFF_8436;
>  		modinfo->eeprom_len = ETH_MODULE_SFF_8436_LEN;

Patch looks fine, but this will only allow user space to decode page
00h. I suggest adding support for the get_module_eeprom_by_page()
ethtool operation in a follow-up patch, so that user space will be able
to query and decode more pages from the CMIS memory map.