netdev - Re: [PATCH v7 18/28] sfc: get endpoint decoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3646edc-281a-1e43-4db3-dd4b29e4ef3f@gmail.com>
Date: Wed, 11 Dec 2024 00:25:52 +0000
From: Edward Cree <ecree.xilinx@...il.com>
To: alejandro.lucero-palau@....com, linux-cxl@...r.kernel.org,
 netdev@...r.kernel.org, dan.j.williams@...el.com, martin.habets@...inx.com,
 edward.cree@....com, davem@...emloft.net, kuba@...nel.org,
 pabeni@...hat.com, edumazet@...gle.com, dave.jiang@...el.com
Cc: Alejandro Lucero <alucerop@....com>
Subject: Re: [PATCH v7 18/28] sfc: get endpoint decoder

On 09/12/2024 18:54, alejandro.lucero-palau@....com wrote:
> From: Alejandro Lucero <alucerop@....com>
> 
> Use cxl api for getting DPA (Device Physical Address) to use through an
> endpoint decoder.
> 
> Signed-off-by: Alejandro Lucero <alucerop@....com>
> Reviewed-by: Martin Habets <habetsm.xilinx@...il.com>

Acked-by: Edward Cree <ecree.xilinx@...il.com>

> +	cxl->cxled = cxl_request_dpa(cxl->cxlmd, true, EFX_CTPIO_BUFFER_SIZE,
> +				     EFX_CTPIO_BUFFER_SIZE);

Just for my education, could you explain what's the difference between
 cxl_dpa_alloc(..., size) and cxl_request_dpa(..., size, size)?  Since
 you're not really making use of the min/max flexibility here, I assume
 there's some other reason for using the latter.  Is it just that it's
 a convenience wrapper that saves open-coding some of the boilerplate?