| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGXJAmxvs3mhqw0xWiy6ppzNE+r9wJbrBjYa+_ZoRXJuh5oRNg@mail.gmail.com>
Date: Wed, 11 Dec 2024 09:29:55 -0800
From: John Ousterhout <ouster@...stanford.edu>
To: kernel test robot <lkp@...el.com>
Cc: netdev@...r.kernel.org, llvm@...ts.linux.dev,
oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH net-next v3 12/12] net: homa: create Makefile and Kconfig
I have now fixed the problems found by the test robot.
-John-
On Tue, Dec 10, 2024 at 4:32 PM kernel test robot <lkp@...el.com> wrote:
>
> Hi John,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on net-next/main]
>
> url: https://github.com/intel-lab-lkp/linux/commits/John-Ousterhout/inet-homa-define-user-visible-API-for-Homa/20241210-055415
> base: net-next/main
> patch link: https://lore.kernel.org/r/20241209175131.3839-14-ouster%40cs.stanford.edu
> patch subject: [PATCH net-next v3 12/12] net: homa: create Makefile and Kconfig
> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241211/202412110709.Kdjua3Pc-lkp@intel.com/config)
> compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241211/202412110709.Kdjua3Pc-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412110709.Kdjua3Pc-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> In file included from net/homa/homa_outgoing.c:7:
> In file included from net/homa/homa_impl.h:12:
> In file included from include/linux/audit.h:13:
> In file included from include/linux/ptrace.h:10:
> In file included from include/linux/pid_namespace.h:7:
> In file included from include/linux/mm.h:2223:
> include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
> 504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~ ^
> 505 | item];
> | ~~~~
> include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
> 511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~ ^
> 512 | NR_VM_NUMA_EVENT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~~
> include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
> 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
> | ~~~~~~~~~~~ ^ ~~~
> include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
> 524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~ ^
> 525 | NR_VM_NUMA_EVENT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~~
> >> net/homa/homa_outgoing.c:809:6: warning: variable 'checks' set but not used [-Wunused-but-set-variable]
> 809 | int checks = 0;
> | ^
> 5 warnings generated.
> --
> In file included from net/homa/homa_sock.c:5:
> In file included from net/homa/homa_impl.h:12:
> In file included from include/linux/audit.h:13:
> In file included from include/linux/ptrace.h:10:
> In file included from include/linux/pid_namespace.h:7:
> In file included from include/linux/mm.h:2223:
> include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
> 504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~ ^
> 505 | item];
> | ~~~~
> include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
> 511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~ ^
> 512 | NR_VM_NUMA_EVENT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~~
> include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
> 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
> | ~~~~~~~~~~~ ^ ~~~
> include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
> 524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~ ^
> 525 | NR_VM_NUMA_EVENT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~~
> >> net/homa/homa_sock.c:224:6: warning: variable 'i' set but not used [-Wunused-but-set-variable]
> 224 | int i;
> | ^
> 5 warnings generated.
> --
> In file included from net/homa/homa_timer.c:7:
> In file included from net/homa/homa_impl.h:12:
> In file included from include/linux/audit.h:13:
> In file included from include/linux/ptrace.h:10:
> In file included from include/linux/pid_namespace.h:7:
> In file included from include/linux/mm.h:2223:
> include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
> 504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~ ^
> 505 | item];
> | ~~~~
> include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
> 511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~ ^
> 512 | NR_VM_NUMA_EVENT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~~
> include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
> 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
> | ~~~~~~~~~~~ ^ ~~~
> include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
> 524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~ ^
> 525 | NR_VM_NUMA_EVENT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~~
> >> net/homa/homa_timer.c:106:6: warning: variable 'total_rpcs' set but not used [-Wunused-but-set-variable]
> 106 | int total_rpcs = 0;
> | ^
> 5 warnings generated.
>
>
> vim +/checks +809 net/homa/homa_outgoing.c
>
> 537f41147b3131 John Ousterhout 2024-12-09 796
> 537f41147b3131 John Ousterhout 2024-12-09 797 /**
> 537f41147b3131 John Ousterhout 2024-12-09 798 * homa_add_to_throttled() - Make sure that an RPC is on the throttled list
> 537f41147b3131 John Ousterhout 2024-12-09 799 * and wake up the pacer thread if necessary.
> 537f41147b3131 John Ousterhout 2024-12-09 800 * @rpc: RPC with outbound packets that have been granted but can't be
> 537f41147b3131 John Ousterhout 2024-12-09 801 * sent because of NIC queue restrictions. Must be locked by caller.
> 537f41147b3131 John Ousterhout 2024-12-09 802 */
> 537f41147b3131 John Ousterhout 2024-12-09 803 void homa_add_to_throttled(struct homa_rpc *rpc)
> 537f41147b3131 John Ousterhout 2024-12-09 804 __must_hold(&rpc->bucket->lock)
> 537f41147b3131 John Ousterhout 2024-12-09 805 {
> 537f41147b3131 John Ousterhout 2024-12-09 806 struct homa *homa = rpc->hsk->homa;
> 537f41147b3131 John Ousterhout 2024-12-09 807 struct homa_rpc *candidate;
> 537f41147b3131 John Ousterhout 2024-12-09 808 int bytes_left;
> 537f41147b3131 John Ousterhout 2024-12-09 @809 int checks = 0;
> 537f41147b3131 John Ousterhout 2024-12-09 810 __u64 now;
> 537f41147b3131 John Ousterhout 2024-12-09 811
> 537f41147b3131 John Ousterhout 2024-12-09 812 if (!list_empty(&rpc->throttled_links))
> 537f41147b3131 John Ousterhout 2024-12-09 813 return;
> 537f41147b3131 John Ousterhout 2024-12-09 814 now = sched_clock();
> 537f41147b3131 John Ousterhout 2024-12-09 815 homa->throttle_add = now;
> 537f41147b3131 John Ousterhout 2024-12-09 816 bytes_left = rpc->msgout.length - rpc->msgout.next_xmit_offset;
> 537f41147b3131 John Ousterhout 2024-12-09 817 homa_throttle_lock(homa);
> 537f41147b3131 John Ousterhout 2024-12-09 818 list_for_each_entry_rcu(candidate, &homa->throttled_rpcs,
> 537f41147b3131 John Ousterhout 2024-12-09 819 throttled_links) {
> 537f41147b3131 John Ousterhout 2024-12-09 820 int bytes_left_cand;
> 537f41147b3131 John Ousterhout 2024-12-09 821
> 537f41147b3131 John Ousterhout 2024-12-09 822 checks++;
> 537f41147b3131 John Ousterhout 2024-12-09 823
> 537f41147b3131 John Ousterhout 2024-12-09 824 /* Watch out: the pacer might have just transmitted the last
> 537f41147b3131 John Ousterhout 2024-12-09 825 * packet from candidate.
> 537f41147b3131 John Ousterhout 2024-12-09 826 */
> 537f41147b3131 John Ousterhout 2024-12-09 827 bytes_left_cand = candidate->msgout.length -
> 537f41147b3131 John Ousterhout 2024-12-09 828 candidate->msgout.next_xmit_offset;
> 537f41147b3131 John Ousterhout 2024-12-09 829 if (bytes_left_cand > bytes_left) {
> 537f41147b3131 John Ousterhout 2024-12-09 830 list_add_tail_rcu(&rpc->throttled_links,
> 537f41147b3131 John Ousterhout 2024-12-09 831 &candidate->throttled_links);
> 537f41147b3131 John Ousterhout 2024-12-09 832 goto done;
> 537f41147b3131 John Ousterhout 2024-12-09 833 }
> 537f41147b3131 John Ousterhout 2024-12-09 834 }
> 537f41147b3131 John Ousterhout 2024-12-09 835 list_add_tail_rcu(&rpc->throttled_links, &homa->throttled_rpcs);
> 537f41147b3131 John Ousterhout 2024-12-09 836 done:
> 537f41147b3131 John Ousterhout 2024-12-09 837 homa_throttle_unlock(homa);
> 537f41147b3131 John Ousterhout 2024-12-09 838 wake_up_process(homa->pacer_kthread);
> 537f41147b3131 John Ousterhout 2024-12-09 839 }
> 537f41147b3131 John Ousterhout 2024-12-09 840
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists