netdev - Re: [PATCH v2 net-next] net: phylink: improve phylink_sfp_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241211211253.d6blsm7zszneu437@skbuf>
Date: Wed, 11 Dec 2024 23:12:53 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v2 net-next] net: phylink: improve
 phylink_sfp_config_phy() error message with empty supported

On Wed, Dec 11, 2024 at 06:03:36PM +0000, Russell King (Oracle) wrote:
> Wouldn't checking phy->drv == NULL be a better to detect that there is
> no PHY driver bound (and thus indicating that the specific driver is
> not loaded?)

Yes, I can do this, and also move the check as the first thing in
phylink_sfp_connect_phy().

pw-bot: cr