netdev - Re: [PATCH net-next v3 11/12] net: homa: create homa_plumbing.c homa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXJAmxC5PkcbXyRuAxa6_uYDPoEE-_RfcE4NmyAHwg_rf9ChQ@mail.gmail.com>
Date: Wed, 11 Dec 2024 15:01:13 -0800
From: John Ousterhout <ouster@...stanford.edu>
To: "D. Wythe" <alibuda@...ux.alibaba.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 11/12] net: homa: create homa_plumbing.c homa_utils.c

On Tue, Dec 10, 2024 at 10:39 PM D. Wythe <alibuda@...ux.alibaba.com> wrote:
> > +
> > +     /* Using a static buffer can produce garbled text under concurrency,
> > +      * but (a) it's unlikely (this code only executes if the opcode is
> > +      * bogus), (b) this is mostly for testing and debugging, and (c) the
> > +      * code below ensures that the string cannot run past the end of the
> > +      * buffer, so the code is safe.
> > +      */
>
> IMMO, Regardless of the scenario you expect to use it in, writing code that
> is clearly buggy is always perplexing.

Fair enough; you have shamed me (appropriately) into changing the code
to use only static strings. This reduces the amount of information
provided if a bogus type is provided, but I don't think that will
matter in practice.

-John-