netdev - Re: [PATCH v2 net-next 12/15] socket: Remove kernel socket conversion.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241210182004.16ce5df7@kernel.org>
Date: Tue, 10 Dec 2024 18:20:04 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Kuniyuki Iwashima <kuni1840@...il.com>,
 <netdev@...r.kernel.org>, Matthieu Baerts <matttbe@...nel.org>, Allison
 Henderson <allison.henderson@...cle.com>, "Steve French"
 <sfrench@...ba.org>, Wenjia Zhang <wenjia@...ux.ibm.com>, Jan Karcher
 <jaka@...ux.ibm.com>, Chuck Lever <chuck.lever@...cle.com>, Jeff Layton
 <jlayton@...nel.org>
Subject: Re: [PATCH v2 net-next 12/15] socket: Remove kernel socket
 conversion.

On Tue, 10 Dec 2024 16:38:26 +0900 Kuniyuki Iwashima wrote:
> +	net = rds_conn_net(conn);
> +
>  	if (rds_conn_path_up(cp)) {
>  		mutex_unlock(&tc->t_conn_path_lock);
>  		return 0;
>  	}
> +
> +	if (!maybe_get_net(net))
> +		return -EINVAL;

FWIW missing unlock here.
-- 
pw-bot: cr