netdev - Re: [PATCH] netconsole: allow selection of egress interface via MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241213103458.GK2110@kernel.org>
Date: Fri, 13 Dec 2024 10:34:58 +0000
From: Simon Horman <horms@...nel.org>
To: Uday Shankar <ushankar@...estorage.com>
Cc: Breno Leitao <leitao@...ian.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] netconsole: allow selection of egress interface via MAC
 address

On Thu, Dec 12, 2024 at 03:31:54PM -0700, Uday Shankar wrote:
> On Thu, Dec 12, 2024 at 10:11:56AM +0000, Simon Horman wrote:
> > Also, as this is a new feature, I wonder if a selftest should be added.
> > Perhaps some variant of netcons_basic.sh as has been done here:
> > 
> > * [PATCH net-next 0/4] netconsole: selftest for userdata overflow
> >   https://lore.kernel.org/netdev/20241204-netcons_overflow_test-v1-0-a85a8d0ace21@debian.org/
> 
> Sure, I can add a test. That patchset does some refactoring that I'd
> like to use though. Can it be merged? It looks like it's ready.

It is in the queue for the maintainers to decide on.
We will see :)

In any case I agree that it makes sense to base your test
on the refactoring in that series, unless that series gets
derailed for some reason.