netdev - Re: [PATCH 1/4] dt-bindings: net: Add Realtek MDIO controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1117d56-87d9-46b2-b6aa-e6ca20bac322@lunn.ch>
Date: Fri, 13 Dec 2024 12:58:25 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc: lee@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	tsbogend@...ha.franken.de, hkallweit1@...il.com,
	linux@...linux.org.uk, markus.stockhausen@....de,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: net: Add Realtek MDIO controller

On Fri, Dec 13, 2024 at 01:56:52PM +1300, Chris Packham wrote:
> Hi Andrew,
> 
> On 13/12/2024 06:13, Andrew Lunn wrote:
> > > +      realtek,smi-address:
> > > +        $ref: /schemas/types.yaml#/definitions/uint32-array
> > > +        description: SMI interface and address for the connected PHY
> > > +        items:
> > > +          - description: SMI interface number associated with the port.
> > > +          - description: SMI address of the PHY for the port.
> > Is the hardware really random here with its mapping of PHYs?
> > Generally, hardware is pretty predictable, logical. I'm just wondering
> > if this property is really required, or if it can be replaced with
> > some logic, avoiding typ0s.
> 
> The hardware is pretty flexible in this respect. You can pretty arbitrarily
> arrange your PHYs. Not all ports support the same kind of SERDES interface
> but as far as the MDIO interface goes you can arrange things however you
> like.

Is there a reason to not just statically define it, maybe with a table
in the driver? Does a DT developer actually need this flexibility?

	Andrew