netdev - Re: [PATCH] ipv4: output metric as unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241213121855.GU2110@kernel.org>
Date: Fri, 13 Dec 2024 12:18:55 +0000
From: Simon Horman <horms@...nel.org>
To: Maximilian Güntner <code@...entner.de>
Cc: netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] ipv4: output metric as unsigned int

On Thu, Dec 12, 2024 at 05:19:11PM +0100, Maximilian Güntner wrote:
> adding a route metric greater than 0x7fff_ffff leads to an
> unintended wrap when printing the underlying u32 as an
> unsigned int (`%d`) thus incorrectly rendering the metric
> as negative.  Formatting using `%u` corrects the issue.
> 
> Signed-off-by: Maximilian Güntner <code@...entner.de>

Reviewed-by: Simon Horman <horms@...nel.org>