netdev - [PATCH net-next 0/4] ethtool get_ts_stats() for DSA and ocelot driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241213140852.1254063-1-vladimir.oltean@nxp.com>
Date: Fri, 13 Dec 2024 16:08:48 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew@...n.ch>,
	Claudiu Manoil <claudiu.manoil@....com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Horatiu Vultur <horatiu.vultur@...rochip.com>,
	Daniel Machon <daniel.machon@...rochip.com>,
	UNGLinuxDriver@...rochip.com,
	Xiaoliang Yang <xiaoliang.yang_1@....com>,
	Yangbo Lu <yangbo.lu@....com>,
	Richard Cochran <richardcochran@...il.com>
Subject: [PATCH net-next 0/4] ethtool get_ts_stats() for DSA and ocelot driver

After a recent patch set with fixes and general restructuring, Jakub asked for
the Felix DSA driver to start reporting standardized statistics for hardware
timestamping:
https://lore.kernel.org/netdev/20241207180640.12da60ed@kernel.org/

Testing follows the same procedure as in the aforementioned series, with PTP
packet loss induced through taprio:

$ ethtool -I --show-time-stamping swp3
Time stamping parameters for swp3:
Capabilities:
        hardware-transmit
        software-transmit
        hardware-receive
        software-receive
        software-system-clock
        hardware-raw-clock
PTP Hardware Clock: 1
Hardware Transmit Timestamp Modes:
        off
        on
        onestep-sync
Hardware Receive Filter Modes:
        none
        ptpv2-l4-event
        ptpv2-l2-event
        ptpv2-event
Statistics:
  tx_pkts: 14591
  tx_lost: 85
  tx_err: 0

Note that the kernel netlink attributes contain a newly added statistics
counter for unconfirmed one-step TX timestamps, which is not printed by
the ethtool user space program yet. I will post a patch once this set is
accepted.

Vladimir Oltean (4):
  net: ethtool: ts: add separate counter for unconfirmed one-step TX
    timestamps
  net: dsa: implement get_ts_stats ethtool operation for user ports
  net: mscc: ocelot: add TX timestamping statistics
  net: dsa: felix: report timestamping stats from the ocelot library

 Documentation/netlink/specs/ethtool.yaml      |  3 ++
 Documentation/networking/ethtool-netlink.rst  | 16 ++++--
 drivers/net/dsa/ocelot/felix.c                |  9 ++++
 drivers/net/ethernet/mscc/ocelot_net.c        | 11 ++++
 drivers/net/ethernet/mscc/ocelot_ptp.c        | 53 +++++++++++++++----
 drivers/net/ethernet/mscc/ocelot_stats.c      | 37 +++++++++++++
 include/linux/ethtool.h                       |  7 +++
 include/net/dsa.h                             |  2 +
 include/soc/mscc/ocelot.h                     | 11 ++++
 .../uapi/linux/ethtool_netlink_generated.h    |  1 +
 net/dsa/user.c                                | 11 ++++
 net/ethtool/tsinfo.c                          |  2 +
 12 files changed, 147 insertions(+), 16 deletions(-)

-- 
2.43.0