netdev - Re: [PATCH net-next] net: page_pool: rename page_pool_is_last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e4cbdd4-691e-45cc-a2eb-c9ae76cc88fe@intel.com>
Date: Fri, 13 Dec 2024 16:43:05 +0100
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <hawk@...nel.org>, <ilias.apalodimas@...aro.org>,
	<asml.silence@...il.com>, <almasrymina@...gle.com>
Subject: Re: [PATCH net-next] net: page_pool: rename page_pool_is_last_ref()

From: Jakub Kicinski <kuba@...nel.org>
Date: Fri, 13 Dec 2024 07:37:59 -0800

> page_pool_is_last_ref() releases a reference while the name,
> to me at least, suggests it just checks if the refcount is 1.
> The semantics of the function are the same as those of
> atomic_dec_and_test() and refcount_dec_and_test(), so just
> use the _and_test() suffix.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Makes sense to me, I think I had issues in the past with references
while developing stuff, as I thought this function doesn't modify
anything :D

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

> ---
> Hopefully this doesn't conflict with anyone's work, I've been
> deferring sending this rename forever because I always look
> at it while reviewing an in-flight series and then I'm worried
> it will conflict.

Thanks,
Olek