netdev - Re: [PATCH net 2/5] netdev: fix repeated netlink messages in queue stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1yqRYMOZRpSjhHG@LQ3V64L9R2>
Date: Fri, 13 Dec 2024 13:42:29 -0800
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, almasrymina@...gle.com,
	amritha.nambiar@...el.com, xuanzhuo@...ux.alibaba.com,
	sdf@...ichev.me
Subject: Re: [PATCH net 2/5] netdev: fix repeated netlink messages in queue
 stats

On Fri, Dec 13, 2024 at 07:22:41AM -0800, Jakub Kicinski wrote:
> The context is supposed to record the next queue do dump,

Same extremely minor nit as in previous patch: "next queue to dump"
?

[...]

> Fixes: ab63a2387cb9 ("netdev: add per-queue statistics")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: jdamato@...tly.com
> CC: almasrymina@...gle.com
> CC: amritha.nambiar@...el.com
> CC: xuanzhuo@...ux.alibaba.com
> CC: sdf@...ichev.me
> ---
>  net/core/netdev-genl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c
> index 9f086b190619..1be8c7c21d19 100644
> --- a/net/core/netdev-genl.c
> +++ b/net/core/netdev-genl.c
> @@ -668,7 +668,7 @@ netdev_nl_stats_by_queue(struct net_device *netdev, struct sk_buff *rsp,
>  					    i, info);
>  		if (err)
>  			return err;
> -		ctx->rxq_idx = i++;
> +		ctx->rxq_idx = ++i;
>  	}
>  	i = ctx->txq_idx;
>  	while (ops->get_queue_stats_tx && i < netdev->real_num_tx_queues) {
> @@ -676,7 +676,7 @@ netdev_nl_stats_by_queue(struct net_device *netdev, struct sk_buff *rsp,
>  					    i, info);
>  		if (err)
>  			return err;
> -		ctx->txq_idx = i++;
> +		ctx->txq_idx = ++i;
>  	}
>  
>  	ctx->rxq_idx = 0;

Reviewed-by: Joe Damato <jdamato@...tly.com>